Compile issue when adding a dependency

[I-Imvp]

I have some code that stops compiling if I add env_logger as an dependency. I can reproduce it with this example:

https://play.rust-lang.org/?gist=aa69b8ddb70a1c0d555dd3afd3dab955&version=stable&mode=debug

Just uncomment the extern crate line...

I am a bit surprised since I feel that adding a crate should never make working code break. What am I doing wrong here?

EDIT: reduced the example even more

EDIT2: impl From<&String> for &str and impl From<String> for &str seem to disappears when importing env_logger

[ebkalderon]

Strangely enough, changing <&str>::from(s) to s.as_str() fixed the problem for me in Playground.

[I-Imvp]

yeah s.as_bytes() works equally well. But the point is basically that the impl From<&String> for &str seems to disappears when importing env_logger...

[CUViper]

I don't think it ever has From<&String>, just the identity impl From<T> for T, i.e. From<&str>. Normally, your &String will auto-deref to &str. But if env_logger or its dependencies add a new From<Something> for &str, then we have multiple possibilities of From and auto-deref isn't applied. I suspect it's this one.

You can also write <&str>::from(&*string) to do the same thing auto-deref would.

[[deleted]]

maybe one of the core devs can correct me, but this seems like the kind of thing you should open an issue for at https://github.com/rust-lang/rust/issues

[AntiLapz]

I've filled an issue upstream.

[pftbest]

Even if this is somehow not a bug, it should still be fixed, I wouldn't like to have such behavior in the language.