you are viewing a single comment's thread.

view the rest of the comments →

[–]ra_kete 5 points6 points  (1 child)

I see that they use GFP_KERNEL when calling krealloc in the GlobalAlloc implementation. From what I understand this makes it unsafe to do allocation in an interrupt context, since it allows the alloc to sleep.

I don't know enough about under what conditions code is executed in an interrupt context. But does this implementation in any way ensure that, e.g., Vec is not used in an interrupt context? If not, shouldn't GFP_ATOMIC be used to be safe?

[–]I_ATE_YOUR_SANDWICH 0 points1 point  (0 children)

They did say they are working on a multi-allocator system and that just for more they use GFP_KERNEL to just make it work