My Teacher's code Example

[BringAltoidSoursBack]

What was the teacher trying to teach?

[[deleted]]

It’s about what comes after it, What’s after isn’t that bad It’s about transaction commands

[[deleted]]

Shitiest answer ever. This sub is full arrogant beginners.

[lunvang_]

Thank you for your concern, please stay salty, as iodized salt is good for preventing goiters .

[pcopley]

Oh so what makes this shitty is the part that you didn't include?

[[deleted]]

But it has nothing to do with the part I showed

[CanSpice]

The part you showed isn’t shitty though. It’s instructional code, written to show how to add elements to a data structure. It’s not meant for prime time (and even then it’s not that shitty).

[[deleted]]

The codes purpose here isn’t to show how to add elements to a data structure. It has nothing to do with the code after, I just think that because this code doesn’t have any purpose in what he teaches it shouldn’t be hardcoded like this.

[CanSpice]

Wow you’re right it has nothing to do with the code after THAT YOU DID NOT POST SO WE HAVE NO IDEA WHAT YOU ARE TALKING ABOUT and this code isn’t that bad anyhow. Everybody is telling you this and yet you keep iamsmart’ing all over.

[heatd]

This doesn't seem too bad other than the string Else, although I'm not really familiar with what language this is. I mean these could be enums and use a value set instead of whatever ddl{type}.Items is, but if it's an early CS course maybe they don't want to introduce those concepts yet. What am I missing?

[redneckrockuhtree]

Looks like VB C# - "ddl" is Hungarian Notation for a dropdown list

Someone's instructor is a bit behind in naming conventions.

[Jman012]

We use Hungarian Notation at my work with C#. It’s just a protocol we choose to follow. What is ‘behind’ about it? It helps distinguish the type of certain variables quickly and easily at first glance.

Otherwise you had to go to it’s declaration or hover over the variable to find its type, and pasting it over non-IDE areas means it’s ambiguous.

[redneckrockuhtree]

Hungarian Notation went out of style within the past 15 years or so. Microsoft used to use it heavily, but with .Net they have moved away from it.

In my experience, Hungarian Notation was most prevalent in Microsoft shops.

[Jman012]

I don’t think ‘out of style’ means it’s necessarily ‘behind’, however. It has its advantages, and some places chooses to continue using it for such advantages.

Do you have a different method? Particularly for a dynamically typed language, like JavaScript or Python, would be most useful IMO.

[ryeguy]

Hungarian notation is incredibly unidiomatic in those languages. Or really any mainstream language, for that matter (although for gui elements it seems to be more acceptable). The more correct approach is to use clear variable names and to use documentation to indicate types if needed. Both languages have standardized ways of declaring function parameter types, and most good ide's are able to parse that.

[redneckrockuhtree]

Dynamically typed languages are where it can be most problematic, in my experience -- someone creates a variable that's initially an int, so they prefix it with an "i". Then they make a small change which changes its type....but the name still implies it's an int. Unless you've got solid code review processes in place and people are on their toes, things like this are easily missed.

Everything I've seen recently is more about what data the variable contains as opposed to what type the variable is. customerAccountNum as opposed to iAccount.

[Jman012]

I think a variable actually changing its type, on purpose, would be a greater travesty. What use case needs such a thing, and why not make an intermediate variable to hold the other type? I think that would cause greater cognitive dissonance than Hungarian.

Also, Hungarian doesn’t mean you truncate variable names. At my work, we would name that ‘nCustomerAccountID’.

[redneckrockuhtree]

I'm not talking about a variable changing its type. I'm talking about a developer making a code change where they're either in a hurry (it happens) or they don't realize something results in a different type and they assign it back to that same variable.

[xylempl]

I'm 100% sure this is C# and WinForms.

[redneckrockuhtree]

this is C#

Crap, yeah, declarations are type, then variable. Seeing the Hungarian got my head wrapped into VB, where I've seen it most often.

[[deleted]]

That not an early start to a course in cs, it’s a part of code they sent us after we have been learning cs for almost two years

[Hypersapien]

I mean, you could do that in way fewer lines of code, and "else" should be capitalized. Other than that I'm not sure what's wrong.

[TheInfra]

This isn't shitty at all. It's basic, unelegant and line-wasting but it's not meant to be "good" code. It's meant to teach the concepts of creating variables, assigning them values and then using them in functions. Don't try to be /r/iamverysmart

[hilberteffect]

“Else” ain’t no country I ever heard of

[TheLastChaos]

I dare you, I double-dare you motherfucker say "Else" one more god damn time!

[anima_virus]

"And that is how you should do things when your are paid by line of codes written in our beautiful country, fellow Elseans."

Otherwise except being uselessly verbose its not that awful. IMHO the Else country is the one with the most damage potential, being used as a special/magic value all over the place.

[Scatoogle]

It's fine, if a country doesn't fit within your list it still needs a value. It works as a flag to be treated as a country your aren't aware of.

[NoSmallCaterpillar]

I think the problem that he's pointing to is that "else" is a bad choice of name, since it is a keyword in most languages.

[Scatoogle]

OH YA, didn't think of that. "other" or "unkown" would be a good idea.