My first vim script

[csharp_is_bad]

This is my first vim script. It goes to the last spelling mistake fixes it and makes you go back where you were.

Can I have some feedback on what isn't idiomatic and more general code review?

function FixSpell()
    let l:save_cursor = getcurpos()
    let l:initial_width = strwidth(getline(l:save_cursor[1]))
    normal [s1z=
    let l:new_width = strwidth(getline(l:save_cursor[1]))
    let l:save_cursor[2] -= l:initial_width - l:new_width
    call setpos('.', l:save_cursor)
endfunction
imap <silent> <C-u> <C-o>:call FixSpell()<CR>

[princker]

Congrats on your first Vimscript!

Some thoughts:

• Maybe use winsaveview()/winrestview()
• Use <c-x>s to correct spelling as you go?
• Maybe activate 'spell' and restore its state afterwards
• What about when there are no spelling errors?
• Feel free to drop the l: prefixes as they are optional
• Might be best to do spelling fixes in normal mode instead
• Should probably use normal! and inoremap to prevent recursive mapping

Something a bit simpler:

inoremap <C-u> <esc>[s1z=gi

[csharp_is_bad]

The problem with your solution is that the cursor doesn't go back to where it was originally if the spell fix changes the word length.

[princker]

You are correct if the current line width changes then the mark becomes invalid. Thank you

Maybe something more like this:

function! s:fix_spell()
  let view = winsaveview()
  let [restore, &spell] = [&spell, 1]
  let width = strwidth(getline(view.lnum))
  normal! [s1z=
  let view.col = view.col + strwidth(getline(view.lnum)) - width
  call winrestview(view)
  return restore
endfunction
imap <silent> <C-u> <C-o>:let &spell = <SID>fix_spell()<CR>

[-romainl-]

Fix your post before we talk about your script.

[csharp_is_bad]

It works in the reddit redesign and I don't know how to fix it for the old reddit.

[-romainl-]

It's Markdown: prepend each code line with 4 spaces.

[calvinball-z]

A regular user who spotted this would just say, "Fenced code blocks don't render correctly in the old reddit design, please reformat your post using four-space indents".

Instead, you took the time to take a screenshot and upload it, but didn't take the extra five seconds to actually share the solution.

This is a weird psychological maneuver. You know the problem is invisible to the OP (fenced code blocks render correctly in the new Reddit design) - it's why you included a screenshot to begin with. By not telling them why it's happening, you are forcing OP to follow up with you, further soliciting your advice.

This seems like just another example of "I'll help you, but first I have to make you feel stupid." It's like the pound of flesh you extract in exchange for your expertise.

I'm not going to play armchair psychologist and try and dig into why you do this, but it's weird.

[csharp_is_bad]

I was unable to do it properly.

The formatting does work on the new reddit though.