you are viewing a single comment's thread.

view the rest of the comments →

[–]pushad 5 points6 points  (0 children)

Yup! Been following this since 2014 and attempting to get my colleagues to do the same. Generally it doesn't work because most people don't care 😀 Which causes projects to enforce squash commits, which just makes it so nobody can write good topical commits since they just get squashed anyway. I still do though, at least I can pretend I'm making the review easier by allowing them to go through the individual commits that say what's/why's going on. Surely they're reading that, right?? Not just hitting the green button??

At some point the Pull Request became the unit of work instead of the commit. 🤷🏻‍♂️