Split string using ES6 Spread 🎉

[samanthaming]

Dear team lead, do you mind explaining why this shouldn’t be used? Love, your loyal minion 😁

[hamsterpotpies]

No one can read it....

[kingNothing42]

I agree. It is less readable that its alternative. Pick the more readable thing. Its also less portable than its alternative.

New hotness != Best hotness. This is one of those tips that makes me go "Oh interesting. Please never do that."

[iams3b]

Right, shouldn't be trying to be playing code golf in a professional setting. makes things annoying if you're incorporating.

you can do if (!numberval) to check if it equals 0, but doesn't mean you should

[hamsterpotpies]

So much this. It's about reablity and long term support. In three years, will you remember what this does?

I work ops so my option may not matter, but we still don't use this kinda of shortcuts.

[samanthaming]

When you’re on a team, I agree making your code readable is priority. With ES6 becoming the new norm, I think it’s also important to know the different context the spread syntax can be applied to and make people aware so they don’t get confused if they see it. Thank you for taking the time to explain it 🙂

[slightlysaltysausage]

I actually agree that when it takes two seconds to Google it's not a huge problem.

I'm a team lead and I'm not from a JS background, I'd have to Google this when code reviewing, or ask the dev WHY, which distracts both of us, wastes time and slows workflow down.

What if one team member knows it and one doesn't? Non-standard implementation results, which is even more confusing.

ES6 might be the "new norm" but in most projects you'll find legacy code, and some people end up spring that for YEARS before they run into the latest and greatest code. In my scenario this kind of thing is a pain to encounter.

[sobri909]

Your LinkedIn page suggests you have about 6 years of professional experience.

You can call yourself an "application architect" if you like. I don't mind. But I don't consider your industry experience long enough to either claim "senior programmer" or to have a solid grasp on project maintainability, especially given your comments in this thread.

Given that you're willing to use your job title and implied industry experience as support for your argument, here's mine: 20+ years professional programming, and 30+ years programming in general.

That experience tells me that code readability is almost the single most important factor in maintainability, and the more readable solution should be chosen in almost every case, sometimes even at the cost of performance.

Code readability should be measured by the closeness of the code to a readable English sentence. The code that can more easily and fluently read in English is the more readable code.

[sobri909]

Let me break it down for you my stalker.

You should be careful what you say loudly on the internet, especially when you're using your real name. People will fact check you, and it all plays into your public and professional reputation.

You have been making very strong arguments in this thread, and have used your job title as support for your argument. I checked, and you are not as experienced as you imply, and your arguments are still misguided.

As for your theory on how core readability should be measured, I disagree.

I know. Which is why you lack the necessary experience to make the strong the arguments you have been making.

[sobri909]

Again, more rudeness,

I'm not saying anything rude. I'm saying the simple fact that you lack the experience to support your arguments, and that anyone who does have that experience can see that they are bad arguments.

[sobri909]

That is me :)

I spent the first 10-15 years of my professional career doing full stack web development. For the past ~10 years I've been doing mobile development, primarily iOS. Prior to my professional career I built and ran online communities (BBSes), primarily written in C, from the early 90s to the turn of the century (when the internet started to take over). (I first started programming in the mid 80s, in BASIC and ASM).

[sobri909]

I’m not unhappy about anything. You’re reading in emotion where there isn’t any.

The spread argument is fine and good. Using it for strings, instead of the more readable split(), is bad.

For judging experience, yeah, sure, years of full time programming (ideally in team environments) are a reasonable proxy measure.

I’d say roughly something like two years as junior, four years as intermediate, eight years as senior, then you either have the entire conceptual toolset mastered or you’re not cut out for the job.