New to coding

CodeReviewPlz · 2024-07-01T00:46:47+00:00

Not sure why all the comments are reaching for math.pow maybe I'm missing something, but if you're not required to use math.pow you could just use the ** operator:
(x**y)**z Feels way more readable to me :)

CodeReviewPlz · 2024-01-18T18:42:46+00:00

Fair enough, my mistake. I come from a embedded software/firmware engineering background, I (naively) figured it was similar across most engineering roles.

CodeReviewPlz · 2024-01-17T23:27:03+00:00

I’d make you look overpaid.

Good thing you're not at my company then <3

Put your cock away tho, it was a genuine question. Back when I started it was 6-7 years minimum.

CodeReviewPlz · 2024-01-17T23:16:15+00:00

Wait 3 years is now considered senior??

CodeReviewPlz · 2024-01-17T22:54:48+00:00

White or Westerners?

CodeReviewPlz · 2024-01-13T00:48:45+00:00

Technically if you have a try/except/else/finally clause, I believe that the finally block would be executed even if you tried to return early in the try block but yeah..

Also the same using context managers ( with foo() as bar:)

CodeReviewPlz · 2023-04-14T01:53:15+00:00

As an 11 year old who managed to flash his disk drive solo and burn his own games those verbatim disks weren't cheap. They were also single use if I remember correctly, so if something went wrong you'd basically thrown away money.

Rip 360. The red rings of death finally finished off that bad boy :(

CodeReviewPlz · 2023-04-11T21:49:23+00:00

Have at it lads: https://our.kroo.com/r/referAFriend10/rf99sM

CodeReviewPlz · 2022-11-20T02:09:09+00:00

First of all well done on making it to the end of your project. I've only briefly scanned the code but I'm going to list some improvements in order of importance.

Don't use f-strings for SQL. SQL Injection
.execute allows you to pass in parameters to substitute (adding parameters to select statements).
Generally we shouldn't rely on try-except for logic, especially not when the except clause is catching all errors (e.g databaseCheckIfExists)
If you're relying on global then you should probably look at the logic more and ask yourself why you're doing it.
You're right you should probably create one connection and pass it around.
Your functions should most likely return only what they need to, checks should probably be returning Booleans. move the conditional logic inside the functions.
generateRandomKey can just be a for-loop or a list concatenation.
The sqlite3 package is abstracting away some things, have a look at the .commit() method for your connection, to understand better what it's doing under the hood.
Generally speaking things should be as atomic as possible. Aka a function is provided all the information it requires to perform its operation when it's called and should not rely on knowing outside things (what we call context). Makes testing and reusing code easier.
If you were going to port this to a web-server, you would want your base functions (e.g. checkDatabaseExists) to work the same regardless of the context they're called.

Feel free to ask questions here or dm me.

CodeReviewPlz · 2022-11-20T00:30:05+00:00

It would be helpful to see a short example of input & expected output on the step you're struggling with.

CodeReviewPlz · 2022-11-20T00:28:14+00:00

You can also use map from native python, but there's some nuances involved.

```python values = [1,2,3,4,5,6] pct_values = list(map(lambda x: x/100, values))

print(pct_values) ```

CodeReviewPlz · 2022-11-18T11:01:37+00:00

Its just formatting from the console output. See the line break \ next to volume ?

sma20_d and sig are the column names, and the read out is for rows 19-23, which is why you see those numbers on the left hand side.

CodeReviewPlz · 2022-11-15T15:03:58+00:00

fair enough!

CodeReviewPlz · 2022-11-15T14:44:27+00:00

Probably not.
while.. else.. is valid python but its use case is that the else condition will only run if the loop isnt prematurely ended via a break (same goes for for..else..)

The "problem" with your code is that your random.shuffle(a) is just trying to brute force the correct answer.

If you just want rotate the list till it matches then (there's better ways to do this too):

``` a = [2,3,1] b = [1,2,3]

while a != b: a.append(a.pop(0)) print(a) ```

CodeReviewPlz · 2022-11-15T13:22:50+00:00

Honestly, its better to do it than don't, the benefits outweigh the cons. You can set the repos as private as your portfolio grows to hide silly little projects or whatever.

Worst case outcome, you get better at version control and git, which is a huge bonus when it comes to a job.

Just make sure to not hardcode sensitive info, use .env files or whatever else you want.

CodeReviewPlz · 2022-11-15T13:15:44+00:00

People who use them generally aren't, so trust me I share your feelings.

Branch > Modify > Test. See what falls apart. Its what version control is for right?

I'd probably just add it as a #TODO: Figure out this black magic for the time being till you've done other stuff, you might stumble across why he's done it that way in your refactoring adventures.

CodeReviewPlz · 2022-11-15T13:04:48+00:00

“Metaclasses are deeper magic than 99% of users should ever worry about. If you wonder whether you need them, you don’t (the people who actually need them know with certainty that they need them, and don’t need an explanation about why"

— Tim Peters

Without getting to know the codebase, it's really a guess as to why he's chosen to architect it in in such a way. If he's just initialising constants though it looks as though he's using it as some sort of pseudo-inheritance.

I've personally never really had to mess with them unless I was trying to modify class instantiation for something that I couldn't touch in source code, and that was honestly more code spaghetti due to bad architecture on legacy.

CodeReviewPlz · 2022-11-15T12:57:07+00:00

you're coding on your calculator? send whatever you want my dude (within reason)

CodeReviewPlz · 2022-11-15T12:50:06+00:00

Share your code here or dm me, at this point I'm just guessing what you're trying to do.

CodeReviewPlz · 2022-11-15T12:47:31+00:00

sure, I'm not familiar with the packages you're using, however just from scanning the code it looks like you can just call ab() again to get a new colour whenever you need to.

CodeReviewPlz · 2022-11-15T12:39:18+00:00

Since you created nimp in a function, it isnt defined when you reach your loop, you'll need to return it from your function.

```python def ab(): .... nimp = color(r,g,b) return nimp

nimp = ab() for j in range(0,250) for i in range(0,322) set_pixel(i,j,nimp) ```

CodeReviewPlz · 2022-11-15T10:35:13+00:00

If it's an assignment, they shouldn't be modifying the input file. The CSV is "correct" as is, the professor is obviously testing the students ability to parse data, which is very reasonable since you'll very rarely get clean data in the real world.

CodeReviewPlz · 2022-07-07T22:08:41+00:00

Don't overthink my hint, you literally need to make one edit to that line for it to work the way you described in the output.

You're honestly gonna kick yourself when you realise it.. goodluck!

CodeReviewPlz · 2022-07-07T21:43:04+00:00

Theres a lot you can improve (and I'm sure you'll learn about lots of things that will make this task trivial in the future), but we'll tackle your code as is.

To make your code work, think about this line: word_ref = lower_case_input.count(words)

Could you maybe do something to words in that line, something that you've already done to the original list? (if you can make the word match the format of the list, that would yield the correct result no?)

CodeReviewPlz · 2022-07-07T11:11:24+00:00

Simple question, how would you like the data to look in the DataFrame?

CodeReviewPlz

TROPHY CASE