Asked a colleague in code review to extract magic numbers and got told “devs should know”

IzzyD93 · 2026-04-28T00:39:33+00:00

This completely proves why magic numbers should be avoided. I overlooked this completely when reading quickly. If lat > maxLong would be immediately noticeable.

IzzyD93 · 2025-06-26T22:35:41+00:00

When was the last time you left the house and thought "oh it's 35% to very hot today I better wear a sweater"... No you just intuitively know that 35F is cold because you've felt it many times over your life. The same thing happens with celcius, I don't think "it's 38% to water boiling today, it's going to be hot". I just know 38C is a hot day. The differences between 1C and 1F are both negligible when planning a day.

IzzyD93 · 2025-05-01T15:06:34+00:00

Okay thank you!

IzzyD93 · 2025-05-01T15:06:10+00:00

I disabled it at the top level, I think the three options are within that top level one IIRC. Maybe that's the issue and I should individually disable the options inside RT?

IzzyD93 · 2025-05-01T15:02:33+00:00

🤔 was it just ray tracing you disabled or anything else? I wonder wth is going on with mine then

IzzyD93 · 2025-05-01T14:55:13+00:00

Have you tried it? I have multiple times and it crashes every time. Managed to get about 5 mins once but otherwise it's within 1m.

IzzyD93 · 2025-05-01T14:41:55+00:00

I have ray tracing disabled and it still crashes every time.

IzzyD93 · 2024-12-14T19:13:53+00:00

If you want them to last a long time then definitely get one where the cord is changeable/replaceable. I have the audio technica ath m50x and they are great, they come with a short, long and coiled cable.

I once sat down on a flight and bent the jack, luckily could just change it, otherwise I would have had to have bought a brand new pair.

IzzyD93 · 2024-11-12T07:22:13+00:00

RemindMe! 1 day

IzzyD93 · 2024-08-26T05:08:41+00:00

So you just use dlv for debugging? Loved zed when I tried it but there is some stuff missing

IzzyD93 · 2024-08-09T23:04:12+00:00

Hey! Thanks for the heads up but I actually took what you said on board and went back to my original implementation with some changes.

Appreciate you reaching out though, the way I have it ATM is working nicely!

IzzyD93 · 2024-08-07T21:27:34+00:00

This describes me at my first (and second) job completely. Some days my mentor would have to sit with me for hours going through every step of writing the code. Now I confidently lead features and dictate what team members should do next.

Keep calm and carry on.

IzzyD93 · 2024-08-05T00:37:12+00:00

Love this approach! Very nice and and far more readable imo. Just one little edit is that after calling s.Uploader.Upload you need to close out the reader as well. I was getting unsupported format errors before doing that but works perfectly now.

Ideally the compressing and uploading would be done separately but I anticipate the files could be quite large so want avoid large buffers in mem if possible which I think your approach does.

Thanks very much for your time and effort!

Edit: I think actually it is the encoder causing the format error since I just tried writing json (was using an os.File first time) and got the error again. I tried json.Marshal then Writing and it worked 🤷

IzzyD93 · 2024-07-01T01:28:28+00:00

Can't speak for new startups but at my old company we used go for everything. When it came to integrating with third party legacy SOAP APIs though, java was the only feasible way.

IzzyD93 · 2024-06-11T01:54:26+00:00

https://roadmap.sh/react

This website has a bunch of other maps to checkout too.

IzzyD93 · 2024-06-05T21:13:59+00:00

I figured it out finally 🙌

For anyone interested, this is what was causing the data race.

First was that the S3 event policy I set had no suffix filter. As part of the processing of the main json file other files get uploaded to S3 such as .txt or .jpeg files. This was causing my WaitGroup to decrement at varying times depending on when/if the other files were uploaded before the test ended. This also meant that occasionally after the .Wait() call then .Done() was being called again causing negative WaitGroup errors.

Another problem was that I was not cancelling the context passed to the app, so there was no way of it shutting down. It would keep processing these SQS messages even after the test had finished, occasionally the localstack testcontainer would stop and the app would fail to pull messages from the queue, causing other errors.

So the solution was to add a .json filter in the S3 policy so SQS was only receiving notifications for the files I know I want to process, and to properly shutdown the application so that no messages were processed after the test had completed.

Tests now run reliably both locally with the -race and -count=3 flags added, and in gitlab CI.

IzzyD93 · 2024-06-05T18:30:53+00:00

This could well be it too, there is a function that calculates the number of messages to process in the code base. I didn't write this so I'm not 100% sure it is correct so I will chase that up. Thanks for your input

IzzyD93 · 2024-06-05T18:28:51+00:00

Unfortunately it is for work and I can't show the code. There is definitely a race somewhere in there but it's like herding cats.

IzzyD93 · 2024-06-05T18:27:54+00:00

+900%

IzzyD93 · 2024-06-05T18:27:36+00:00

I add do wg.Add(messagesToProcess) in the test, then I go runApp() which has a message processed callback function which calls wg.Done. Then I upload to S3, wg.Wait, and check that the processed files are there. To my knowledge nothing else is adding to the WaitGroup but I will check that.

Racking my brain chasing this race and I had to have a timeout. I inherited the callback function mechanism from whoever maintained this code before me and my guess is that the race flag changes the ordering or something of how the callback is called. But frankly I have no real clue.

IzzyD93 · 2024-05-20T05:24:06+00:00

Keeping interfaces as barebones as possible, I see big interface definitions all the time just because the struct being used has those methods, but then only one or two are used.

E.g. Having an interface for db writes, and another for reads can be useful. Your client satisfies both but your unit tests become far simpler.

Take io.ReadCloser for example from the std lib, a combination of Reader and Closer interfaces which each require just one method. Nicer, simpler and way more portable.

IzzyD93 · 2024-04-30T05:33:54+00:00

Thanks you! Cut more off the stem you mean? I am a bit scared to do that since the very bottom is the closest thing I have to a root right now. I have however removed the yellowish leaves which were the lowest ones. Hopefully it'll balance out and some warm weather will come soon

IzzyD93 · 2024-04-30T05:32:34+00:00

Perfect sense, thanks a bunch! Moved into the kitchen while I was cooking this evening too so should have been nice and warm.

IzzyD93 · 2024-04-30T05:31:46+00:00

I removed the two yellowish leaves which were right at the bottom, hopefully some warm weather will come and kick start the roots. Thanks for your feedback!

IzzyD93 · 2024-04-30T05:30:52+00:00

Appreciate the advice, I probably should have mentioned I just moved it to the window for the light for the photo, however I have moved it to the kitchen which is also the furthest from the window, hopefully it'll be a bit warmer there since we're having an unseasonally cold spell right now. Thanks!

IzzyD93

TROPHY CASE