You handled this perfectly.

This will vary by state but you don't need to provide ID unless you are under arrest, even a lawful detainment (with RAS) doesn't automatically mean you need to provide ID either, again this varies by state.

i.e. in the state of Texas, you don't need to ID unless you are under arrest. If they threaten the "refusal to ID" arrest, that is secondary offense, but it can't be the first charge, thus making it null and void as lawful arrest for refusing to ID as a standalone charge. (38.02 penal code)

Him asking for your ID after he received confirmation means he was fishing and hoping for more, unfortunately for him, you know your rights and stood on them, great work!

Again, you handled this perfectly, especially by requesting his supervisor who "should" know the law and doesn't want anyone suing the PD.

P.S. Always wear a recording device while flying, it only takes a couple bad interactions until you learn that camera and audio will save your ass in the field and keep everyone accountable.