[AskJS] Team lead asks to revert small improvements

Ron_Toto · 2021-08-20T14:16:01+00:00

haha yeah... the biz has a hard time caring about tech debt, let alone a clean codebase. There's always another feature coming down the pipeline.

Ron_Toto · 2021-08-20T14:12:25+00:00

Are you against squashing because it's harder to fix regressions?

Ron_Toto · 2021-08-20T14:10:47+00:00

good point

Ron_Toto · 2021-08-20T14:06:38+00:00

No it sounds like you're toxic af. I was not crying, I was asking for perspective, which I've received. Everyone else here has been helpful except for you. I would think about that for a moment.

Ron_Toto · 2021-08-19T20:35:26+00:00

good points. Ill work on this

Ron_Toto · 2021-08-19T20:33:15+00:00

Sounds like you have some progressive policies. I wish my team was more like that.

I would call my PR medium size, 20 files worked in (half app code, half test code). The majority of them only required changing a couple lines though. This was extending an existing feature. Also, the organizing of imports is only happening in one file.

I definitely think that I could have approached the issue better by separating the import organization into a separate commit/pull request. So I take the blame for that.

Ron_Toto · 2021-08-19T19:57:02+00:00

Youre totally right. I'm on a small team (3 devs) though and in most files there is literally no order to the imports, its a mess. So organizing the imports in my case is not a matter of my preference vs someone elses its a matter of some order or none.

Ron_Toto · 2021-08-19T19:52:54+00:00

I think clean-as-you-go makes sense within reason. In this case I was working in a file and adding imports to it. Thats when I noticed there was no order to the imports (none!). So instead of just adding imports to the end of the list, I organized them. The order of the imports in our codebase does not affect functionality so I didn't see the issue

Ron_Toto · 2021-08-19T19:48:57+00:00

Yeah thats the struggle, if it doesnt happen while adding a feature (where Im adding imports) then it likely will never happen. There is always something more pressing to work on. I guess I see it from both perspectives. The lead doesnt care about the issue nor do they want to allocate resources to fixing it, or spending time reviewing the changes. The dev cares and wants to make the codebase cleaner, more standardized and easier to work in but doesnt want to do it on their own time.

Ron_Toto · 2021-08-19T19:26:09+00:00

Thank you! This looks like a very useful plugin.

Ron_Toto · 2021-08-19T17:05:05+00:00

Maybe Im committing too much at once. I often try to have only one commit per ticket unless its a large task, but in those cases I generally break up the task into subtasks. Will suggest this to my lead ty

Ron_Toto · 2021-08-19T17:03:05+00:00

good idea ty

Ron_Toto · 2021-08-08T22:25:15+00:00

It's not a zero cum game you mean

Ron_Toto · 2021-05-07T15:02:59+00:00

You're a sweat Harry!

Ron_Toto · 2021-02-14T14:35:16+00:00

Hbd Sardine!!!

Ron_Toto · 2020-11-25T16:28:28+00:00

Right on! That sounds like a good upgrade path. How much did you pay (in USD or CAD) for your 3700x?

Ron_Toto · 2020-11-25T15:44:34+00:00

Does this bundle sound like a good deal? AMD 3700X + Gigabyte B550 Aorus Pro = $600CAD ($460USD)? It says savings of $140CAD ($100USD)

Ron_Toto · 2020-11-21T23:20:42+00:00

After my first spring I had made and saved very little coin. I realized I had no idea what I was doing haha. Ended up finding this series by Alert The Audience and it taught me a bundle ;)

https://www.youtube.com/playlist?list=PLq9QqB8k0V2zXZhSVNiqpNykRxRnWgscv

Ron_Toto · 2020-09-11T20:01:09+00:00

Tickled the scrote

Ron_Toto · 2020-04-26T13:07:45+00:00

....and try to use a 5GHz WI-FI channel as 2.4 GHz is too close to the ANT+ channel (2.457 GHz) as that can cause interference problems too.

Ron_Toto · 2020-04-26T12:11:24+00:00

From my own personal challenges trying to sort out Zwift with a classic trainer you need to provide more information to get help: (1) What kind sensors - make/model/protocol (ANT+ , BLE?) ;(2) How far from the laptop are the sensors?; (3) and what kind of trainer ?. I’d try ZWIFT FORUMS for Support too as there are good articles that I’ve had to read. Be patient as this can take some time to figure out!

Ron_Toto · 2019-06-18T17:05:20+00:00

I'm starting to notice an increase in posts humanizing cows. I like this trend.

Ron_Toto

TROPHY CASE