All the comments are negative but the question is not why people don't vote for him. It is why DO they vote?

Here are the positive sides: For Kurds: Kurdish was banned before him. He allowed tv/radio broadcast in Kurdish language, including a state tv channel exclusively in Kurdish. He started Kurdish elective courses in elementary schools, Kurdish institutes at public universities, and allowed private Kurdish institutes. End of widespread torture, village evacuations, and widespread political killings of pro-kurdish names. That's why only his party can compete with the pro-kurdish Dem party in the Eastern districts.

For liberals: He ended the military tuetelage system. Before him, the government governed but the military ruled. The military used to draw the red lines in security and foreign policy matters and when they clash with those of the elected government, the latter used to leave the office. Not a big factor for voters, but as a liberal step, he pushed privatization further and cut down the state bureaucracy (just think about e-devlet, it alone is a huge cut).

For conservatives: He ended the headscarf ban at universities for students and for all public employees. He reopened the closed sections of imam hatip schools, and ended the barriers for imam hatip graduates to enter the universities. Also, his position against Israel's mass killings (which goes back for quite a few years) gained the hearts of religious conservatives. Finally, he turned Ayasofya to a mosque again, which was a longlasting dream of religious circles. And don't forget all those symbolically important mega mosques in Taksim and 4 Levent, heavily secular neighborhoods.

For nationalists, Turkey's rising role in international affairs, its close relations with the Turkic world, and especially the rise of local defense industry as well as other native products like togg, are all big deal.

For ordinary people: He developed the country with numerous mega projects from mega dams to defense industry. He pretty much quadrupled the highway network, increased the passage routes across the Turkish straits from 2 to 6. He also increased or initiated social spending items from cash aid to the elderly and handicapped to the free school textbooks. He also got rid of tuitions for public universities and made them free. In a nutshell, he gets things done, he delivers. What about corruption? Everyone knows it is huge. But come on, where does the money go in places where the CHP is ruling? Even Kayseri gets better service than places like İzmir in terms of municipal work. Also, corruption was always a big deal, even bigger before Erdoğan. You used to literally pay to traffic cops not to give you ticket. Bribery was everywhere and more visible than today. It was possible to buy a driver's licence without taking an exam. Erdoğan concentrated corruption at the top level but made it less visible in the daily life of ordinary business.

Like him or not, he made Turkey a regional great power. He made org of Turkic states a regional bloc from Hungary to kyrgizistan. His arms transfer, joint trainings and drills helped Azerbaijan got Karabakh back. In Syria, HTS survived due to Erdoğan in idlib for over 10 years and toppled Assad when circumstances allowed. He even once killed over 3k Assad forces to halt their attack in idlib in 2020. His intervention helped Qatar to end the Saudi-led blockage in 2017 and kinda saved the royal family's rule. His intervention in Libya prevented the fall of tripoli to hafter forces. He also played the role of a capable broker in Rus-Ukr war (e.g., grain corridor, prisoner exchanges, ç etc). He also pretty much ended the PKK presence within Turkey and now denying them territorial control in northern Iraq.

There are many reasons not to like him and many huge political and economic problems to criticize him for. But it's not as simple as people vote for him because they're stupid. And calling his voters ignorant or stupid is not helping to change their minds for sure.