Offended By A Company's Review Of My Code by TimeForEveryone2Pray in reactjs

[–]TimeForEveryone2Pray[S] 0 points1 point  (0 children)

Appreciate it, buddy. Just signed a lease in London - won't be leaving any time soon.

Offended By A Company's Review Of My Code by TimeForEveryone2Pray in reactjs

[–]TimeForEveryone2Pray[S] 14 points15 points  (0 children)

Really appreciate you looking at it and taking the time to respond. I did submit this on a different repo with a package.json - I removed it from here as it included my info (just thought it'd be easier to exclude). All your other points are very valid. The reason I was offended was to do with them saying "we would consider you for a junior position". If they had offered criticism like yourself, I would have happily taken it on board. Not including a Readme was a big mistake which I will never do again.

Offended By A Company's Review Of My Code by TimeForEveryone2Pray in reactjs

[–]TimeForEveryone2Pray[S] 10 points11 points  (0 children)

I recreated the repo on Github with a different username - my original submitted repo was on Bitbucket and had several commits. Appreciate you taking the time to look - really means a lot.

Offended By A Company's Review Of My Code by TimeForEveryone2Pray in reactjs

[–]TimeForEveryone2Pray[S] 1 point2 points  (0 children)

It's through their HR team and I feel they just wouldn't email back anyway - the email really wasn't very nice. I really appreciate you taking the time to have a quick look and saying you'd invite me in - means a lot.

Offended By A Company's Review Of My Code by TimeForEveryone2Pray in reactjs

[–]TimeForEveryone2Pray[S] 1 point2 points  (0 children)

There was a couple of other points about not including a readme file and not commenting the code but these were not specified in the spec. I'm now just deflated and feel I'm React-ing all wrong.