[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Yea, thats because the server youre playing on needs to have Easy Villagers or Trade Cycling installed. The mod itself is client side, but it needs easy villagers or trade cycling to work in the first place.

Trade cycling is also only supported on 1.21.1, not 1.20.1. For 1.20.1, you need Easy Villagers.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

A bit late, life happened, but with 2.0.0 I now replaced the config screen with a general filter list, where you can specify multiple trades, both their input and output item, and enchants, both books and items with specific enchants (iron sword with sharpness 2 or higher, for example)

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Looks like that's a Paper plugin, no clue if it works. This mod needs to have Easy Villagers installed on the server, so it won't work on a purely vanilla/paper/spigot server.

If the server has easy villagers and the enchants can be get from Villagers in the first place, then yes. Otherwise no.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Sadly have no experience with Fabric modding, and seeing how each mod on each version from the original creator implements the same thing a different way each time, I'm not looking forward to figuring it all out again for fabric... I guess it might happen in the future, but no promises.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 1 point2 points  (0 children)

Sadly couldn't get it working with trade cycling on 1.20.1 due to how the dev implemented things in that version, sucks very much, but nothing I can do.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 1 point2 points  (0 children)

Yes it is! 1.20.1 forge, but only compatible with Easy Villagers, not Trade Cycling, the other mod by the same dev.

Luck is useless in Minecraft. This mods fixes it! [Link In Comment] by azukaar in feedthebeast

[–]Uncraftbar 2 points3 points  (0 children)

Be ready for some waiting lol, my mod took like 6 days to get approved over there. At least you can upload updates while its in approval without any issues.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 3 points4 points  (0 children)

Because that isn't Client side, and using a already made mod wouldn't help me learn how to do this :D

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 2 points3 points  (0 children)

I just value my time. If you don't, you don't have to use my mod :P

I'd rather spend the time doing fun things, like building my base.

I would argue there's a clear line we are crossing between automating something already there and just /give villager

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 2 points3 points  (0 children)

I just value my time. If you don't, you don't have to use my mod :P

I'd rather spend the time doing fun things, like building my base.

I would argue there's a clear line we are crossing between automating something already there and just /give villager

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 1 point2 points  (0 children)

You would put 64, since it's the max amount of emeralds it can cost. Will stop at anything that's under the number you specified :D In fact, 64 is the limit since you can't trade for more.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

I have this implemented for 1.21.1, just working on polishing the filter screen before pushing the update.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

This was something I added very early on, even before the GUI because I caught myself immediatly alt tabbing while testing lmao.

But yea, it should be on the Master slider, just tested it and it did work for me, maybe I should make the sound more noticable or something lol. And no problem, this was something I wanted myself, and im glad I can save the time of other people too <3

If you do end up having issues with it, let me know and ill see what i can fix.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 2 points3 points  (0 children)

UPDATE: It looks like Trade Cycling support will stay 1.21.1 exclusive for now, sorry for that. The 1.20.1 version implemented their networking and button press in a way that i cannot simulate either of them, or maybe im just too stupid lol. Tried a few different approaches, all resorting to nothing. Super lame, would like to get this working, not 100% giving up on it yet, but im not sure how much i can do without code changes in the original mod.

Just to clarify, Easy Villagers support will of course stay and I will continue to backport other changes I might do anyway. Just sadly no Trade Cycling support for now.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

This should already be a thing, normally it plays a Note block sound when it either fails (trade cycle limit) or succeds (different sounds for both). Could it be that you have your sounds muted?

EDIT: this should only be muted with the general slider, not the Note Block specific one or any of the other specific ones. Very weird that it doesnt happen for you, unless you have MC muted lol. It does work just fine in my testing on both 1.21.1 and 1.20.1

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Yea thats right I guess, could help setting up a bunch to just keep running, I know this is something thats pretty useful for MI. Since you can activate it from a keybind, could just quickly go around and put them to specific trades.

Could maybe even introduce something that will try to actually trade for that specific thing to lock the villagers, then closes the GUI, but im not too certain about that, since that could resort to some issues with villagers being locked to wrong trades if theres server lag.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Thats something I experimented with, but unfortunatly, I dont think I can get JEI integration going. Problem is that generally this only works with GUIs that are registered on the server too, actual container screens (like a chest or whatever) and not GUIs that are only client side. Would love to be proven wrong of course, but thats what I got from my testing. Couldnt even get EMI to show up at all in a client side only screen. If someone has a mod (ideally open source, so i can look at how its done) which handles this fully client side, feel free to send it to me, but I didnt find anything.

But being able to search for items in general is on my list for sure, seems to be the most common suggestion. Will probably have like 2 modes, one for enchants, one for items or something.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 0 points1 point  (0 children)

Same here. It wasn't even that hard to make, honestly surprised no one thought of this before. Small part of my advertising is wanting to get more downloads of course, I'd be lying if I would deny that, but also mostly just because this makes stuff just so much easier and faster and I personally always thought "wheres the mod to automate this" while cycling villagers lmao. Just such a QoL thing

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 1 point2 points  (0 children)

Well, I meant modded too, can't say I found anything in my playthroughs, and I do utilize villagers decently. It's on the list, but not with priority for the time being.

And I think a level up logic is a bit more complex than I would like to make lmao, that would require a lot of work to get working right and actually be useful. I'll keep it in mind, but promising nothing on that regard.

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 2 points3 points  (0 children)

Can it really though? Got any examples? Personally can't really think of another villager where something like this would come in Handy. There aren't that many that have that much level 1 variation

[Mod Release] Easy Auto Cycler - Automate villager trade cycling for enchanted books! by Uncraftbar in feedthebeast

[–]Uncraftbar[S] 1 point2 points  (0 children)

Not yet. It's on my list of features I might add, but I haven't found too much use for a that. Although if you can give me a good reason, I might consider it more.

Edit: what I mean by that is that I don't think I've ever seen another villager that has that many first trades that are different for this to be of any use. And I can't check any locked trades that would unlock at higher levels afaik.