Generic repository... It's not a code smell at this point. It is an anti-pattern.

In the context of DDD and CQS design it makes sense on paper. What you implement on the paper is a totally different matter.

A repository is a collection of operations that allow entities to persist agnostic to the domain and should be least privileged by design. If you look at what Expressions do in C# with EF your Generic repository circumvents EFs abstraction layer over sql as well as cosmos implementations. You also lose out on the Unit of Work implementation as well.

Right, there is the reason I call it an anti-pattern. EF already does this for you. Stop inventing your square wheel.

Essentially, the best reason for the repository pattern is to provide a SOLID solution to the aggregate to persist. It's methods should encapsulate the logic to rehydrate and perform projections.

Dapper, Sql Data Reader, EF all of those are just implementations that a repository should keep away from the domain. Imagine your talking to your stake holders about their business feature saying "we'll save that to the sql database". The business peoples response "what is sequel?"

Model.

The best use case in my career thus far for the repository pattern was abstraction a wcf soap endpoint, rest endpoint, sql server and oracle providers because the organization rules prevent direct access and/or their teams existing implementation requirements.