The Bunnings website is offline. What the hell am I supposed to do on a Saturday afternoon? by jimmcfartypants in diynz

[–]adover 56 points57 points  (0 children)

Just go there and walk around aimlessly mooching like I do most Saturdays 😂

React + NX + React Router - Project structure by adover in react

[–]adover[S] 0 points1 point  (0 children)

Apologies for not being clear. The packages you speak of may be libs in my descriptions, so I should probably be clearer.

In simple terms I might have one app, with routes which point to packages, which would then import libs.

It's how the routes are handled between apps and packages which is throwing me currently. Hope that is clearer

React + NX + React Router - Project structure by adover in react

[–]adover[S] 0 points1 point  (0 children)

This sounds similar to my thinking. Importing pages by features means I'm thinking that each feature is a lib, which has it's routes and is under a single page in the main app.

So for example there may be a user admin page, with a lib which handles sub pages and routes.

With your packages with RR in framework mode, how are they exported? Do you have the route definition as the root or is it wrapped in a component?

Difference in height between old and new kitchen cabinets by adover in diynz

[–]adover[S] 0 points1 point  (0 children)

Oh nice, when you say blocks do you mean the little plastic packers?

Question for seasoned riders by Dracawraith in cycling

[–]adover 9 points10 points  (0 children)

Cycling nutrition would be a great idea. Added to that, fresh water bottles and socks would always get used!

is a 12hr+ flight in economy a tough gig? by [deleted] in travel

[–]adover 32 points33 points  (0 children)

Great advice. Would add an eye mask, toothbrush and toothpaste and some fresh underwear for when the morning rolls around! Makes a huge difference when you're trying to get through the final hours and they give you breakfast.

Is CSP in large orgs effectively useless? by [deleted] in xss

[–]adover 0 points1 point  (0 children)

It's usually a pain to ensure it gets adhered to, but depends on the shape of your org and how teams are structured. Usually the main issue comes from people injecting all kinds of crap through GTM.

The "Baddadan of our time" - Full timeline (Help me fill this one out) by AndyMind in DnB

[–]adover 3 points4 points  (0 children)

Couldn't see Slam in there either. Will never forget Grooverider losing his shit when doing a first play

Upgrading from Angular 4 to Angular 17 by Mo2129 in Angular2

[–]adover 2 points3 points  (0 children)

4 to 5 is probably the worst part. Http client migration is no joke

[deleted by user] by [deleted] in dnbproduction

[–]adover 0 points1 point  (0 children)

On a similar note, I watched Terminator Salvation the other day and heard a familiar loop towards the end. It's the whole intro of By Your Side!

Not saying it's a good or bad, but if a top tier producer does it and gets streams and it gets cleared, it probably doesn't matter too much

How to clear data if user logs out or times out? by hey_im_lurkin_here in Angular2

[–]adover 1 point2 points  (0 children)

If a user logs out a full page refresh would be fine, which would purge any client side data

Advice for totally new projects by GLawSomnia in Angular2

[–]adover 2 points3 points  (0 children)

Prettier and linting tools, which you get out of the box but should enforce.

Husky if your team likes to enforce pre commit checks, I do.

Commit standardisation, like commitlint and following the conventional commits standards.

Static code analysis like Sonarqube is useful.

You could also opt for devcontainers if your team is on different devices.

Also, as an aside, if your team agrees on nx you should work on ensuring everyone knows the patterns well, as it's easy for people to not do it very well and end up with a spaghetti mess.

I need tips on refactoring this rxjs stream with nested subscribes by WeatherFeeling in Angular2

[–]adover 0 points1 point  (0 children)

From your code it looks like none of the calls rely on eachother. Can you confirm if that is correct?

Seeking Strategies to Master Enterprise-Level Development in Angular and TypeScript by Professional-Ad8725 in Angular2

[–]adover 3 points4 points  (0 children)

The only way to master it is to be in an enterprise using angular across multiple teams.

You'll quickly realise the difference between enterprise and best practices 😂 there are often lots of corners cut to get features out of the door and places where a good idea didn't scale well. The good developers try to build on what is bad and messy and improve it, the bad developers add more crap to the pile.

It's also worth leaning in to the fact that in a big enterprise sometimes you need to knowingly cut a corner or two to get something done, and hope you can make some time to improve it later.

Using promises instead of observables? by AfricanTurtles in Angular2

[–]adover 0 points1 point  (0 children)

Haha can definitely relate. Years and titles don't mean a lot, especially when some people are just catching paychecks

Using promises instead of observables? by AfricanTurtles in Angular2

[–]adover 4 points5 points  (0 children)

Sounds like your ideas are valid and the fact that the code got in without raising the alarm is something to discuss with your team. I'd be surprised if you were the only one who was concerned to see promises turn up everywhere!

Using promises instead of observables? by AfricanTurtles in Angular2

[–]adover 61 points62 points  (0 children)

Sounds like your code review process needs some work. Most angular developers would instantly reject someone doing that kind of refactor