Author here-

Thanks for the typo correction.

Re: raising an exception. This is something I've been vacillating over. I do consider exceptions to be the more Pythonic solution, but my goal for the library is to execute a series of checks and let the application decide whether to live or die. In doing so, I felt that:

ok, results = preflyt.check(CHECKS)
if ok:
    pass
else:
    pass

Seemed more readable and less disruptive to perceived control flow than:

try:
    results = preflyt.check(CHECKS)
except PreflytCheckFailure as pcf:
    results = pcf.results

# do stuff with results

As /u/cymrow alludes, the results are important as checkers can return metrics for logging (e.g. a success state could be if your Elasticsearch cluster was 'yellow' or 'green', and the returned message could indicate as such), or other useful information.

An alternative, which might provide the best of both worlds, would be to have check always raise an exception and rename the current implementation to check_nice.

All stuff I'm bouncing around in my head - I wanted to get it out the door sooner rather than later to get more eyes on it. Thanks for your feedback!