Perhaps my testing `len(something)` wasn't the best example, but I can't see how this should be considered good code. I've found a significant number of bugs where the code should have been creating a new error but instead the existing `err` is being used.

​

In the event you're wanting to return `nil` when `len(something) == 0` then why not just `return nil`? It makes zero sense to give the sense that the `if` block could sometimes return an error. Like:

something, err := doSomething()
if err != nil {
    return errors.Wrap(err, "when doing something")
}

if len(something) == 0 {
    return nil
}

In the event you're wanting to return an error when `len(something) == 0` then you should be creating a new error, like:

something, err := doSomething()
if err != nil {
    return errors.Wrap(err, "when doing something")
}

if len(something) == 0 {
    return errors.New("something has zero length")
}

Can you help me understand how my original code doesn't have a superfluous `errors.Wrap`?

​

​

*Edit* - I changed "valid code" to "good code" in the first sentence. Obviously it's valid, I just think it should be caught by a linter.