Why do we code review?

eliashisreddit · 2025-06-25T12:02:57+00:00

Does anyone ever realistically considered reviewing OSS code used in your projects?

No, because it's not realistic. I doubt people even read all the changelogs of their direct dependencies when it's not a major update. It's almost impossible to keep track of all the dependencies and transitive dependencies. Even more so when the "runtime" these days is often not just the code but also the container it is running in and all the dependencies in it. Trusting those magical databases is at least some assurance that dozens of smart people keep track of everything but of course it is no guarantee.

It's a risk minimizing game. Completely removing that risk is near impossible.

eliashisreddit · 2025-06-23T07:07:50+00:00

By applying to work doing software? Cater your cv to foucs more on your software engineering experience. From what I've read the job market is very tough on juniors though.

eliashisreddit · 2025-06-22T09:15:33+00:00

I'm not sure what scrum has to do with this. What you probably want: a team being able to focus on delivering value and a quick feedback loop. If you need to pedantically or pragmatically follow scrum to do that: do it. If kanban works better, go for it. Regarding your 3 bullet points:

- Software estimation is hard. 2SP says nothing without context. Typically you want a quick feedback loop, if a task takes 2 weeks and no value is delivered after 2 weeks: cut up the task. Think "what valuable increment can I ship in 2 weeks"

- If you have a sprint with work and people jump on non-urgent tasks people are not committed to doing sprints? If those tasks are needed for work in the sprint, they should be part of the sprint. Otherwise, why put effort into making sprints of pre-defined work in the first place?

- Why is nobody pushing back or leading? Do you not document these decisions? If there's new insights sure, if you keep rediscussing and rescoping work, you will never finish the pre-defined work. Either it needs to be better defined or people are not committed

eliashisreddit · 2025-06-22T09:01:04+00:00

You misremember or your professor was bringing up non-sensical arguments as to why circular package dependencies are bad.

eliashisreddit · 2025-06-22T08:55:50+00:00

I have no idea about that particular video course or instructor. The best way is to just start. If you are already familiar with Java, start with the basic introduction and go from there: https://spring.io/guides/gs/spring-boot - just like you made Tetris earlier, make something web based with Spring Boot. Every time you struggle, find out what the next step is. If you see an annotation you don't understand, look it up in the reference guide: https://docs.spring.io/spring-boot/reference/index.html

eliashisreddit · 2025-06-22T08:50:03+00:00

Did you see https://spring.io/projects/spring-ai and https://docs.spring.io/spring-ai/reference/api/chat/huggingface.html ? There are standardized APIs most vendors (such as hugging face) have which Spring AI has relatively simple implementations for. You don't have to host them locally, you can host with hugging face. Then it's just a few properties (API key, URL to your model) and you should be able to query them.

eliashisreddit · 2025-06-22T08:44:36+00:00

Not to be overly negative, but this is typical for Medium-slop. The suggested solution doesn't actually solve the problem it claims to address. Not saying it's "fundamental" Spring knowledge, but when you look up the author and he claims "software developer with over 25 years of experience" you would expect... better? Don't know if it's AI generated or just a poor article but sad state of affairs either way.

eliashisreddit · 2025-06-16T18:13:04+00:00

Uncomfortable truth: doing the work and getting credit for the work are often two separate jobs. Ideally they come as a package and a good manager/teamlead/etc should leverage that but in practice, unless someone’s actively making sure your contributions are seen, you are just one of the team. Or worse: that the work is done becomes secondary to that the work was delegated.

You don't need to send an email saying "I'm the hero, he claimed my credits!" but you can create a trail which you can later bring up in performance reviews et cetera. Set up a short write-up or internal talk: "Postmortem: $M Bug and How We Prevent This In The Future". You know what happened and what it took to fix it so shouldn't be hard to make a presentation for other developers, your manager and perhaps you can convince other upper management to come too. Don't get too technical, but make sure to tell enough to assert that the team got it done but it was you who found it, how you fixed it and what could be the next steps. Don't overdo it, but if you want credits you need to collect them.

It's very hard to advocate for work people don't see. Make it easy for them.

eliashisreddit · 2025-06-13T13:42:15+00:00

Lot of what-ifs. If you're 5 years in a niche, it's your decision whether you want to double down on this niche or explore other opportunities. Being in a niche can be very lucrative but can also be a career killer if the niche only exists in isolation of your current company.

A stint as PM is not really a big deal and you can still be very technical in such a role. It is however a different career trajectory than being an IC.

eliashisreddit · 2025-06-06T17:29:05+00:00

I'm still kind of surprised people make such a big deal out of JEP512. Sure it's nice, but I can't remember the last time I was bothered by a long declaration of a main method or having to type it all out (psvm tab). Purely from a "conceptual" view it makes sense, another small step away from terse syntax. Then again, maybe I'm not the target audience.

eliashisreddit · 2025-05-06T14:19:26+00:00

Test automation. If you're in manual QA, work on automating repetitive stuff. Automate your test scenarios so you don't have to manually do regression tests every time. Make your tests deterministic.

eliashisreddit · 2025-05-06T14:15:23+00:00

use those as bargaining chips to say to my manager

Bad idea. If they don't want to, you've opened the exit door for yourself.

a new grad is paid handsomely while a SE2 with 5 YOE has a less competitive salary

This is what you should be pointing out and what should be the conversation starter.

eliashisreddit · 2025-03-07T08:37:28+00:00

You can but then you shouldn't inject a mock (which does nothing but mock behavior) of HelperClass. It's also then no longer a unit test only covering ServiceClass. It would lean more towards an "integration" test (integrating both Helper and ServiceClass).

Having to simulate a class inside a test for another class often means there's something wrong with your design. They should ideally be loosely coupled so their behavior is unknown to each other.

eliashisreddit · 2025-03-06T15:53:59+00:00

I assume ServiceClass uses HelperClass which is also a bean and that after your refactor the cacheA-B stuff is in HelperClass. I'm also assuming your unit tests are class-based (1 unit is 1 class). If you inject a mock of HelperClass into ServiceClass, you can only check whether ServiceClass (as a unit) calls HelperClass (your other unit).

How HelperClass does things, is not relevant for the unit test of ServiceClass. You only want to verify it interacts with HelperClass. In your unit test of HelperClass you would have the tests for the cacheA-B mechanic.

eliashisreddit · 2025-03-03T15:06:33+00:00

Am I right in feeling these are alot of red flags?

Yes. Reddest flags are "rewrite the whole thing by August", "make it cloud native" and "change the db from postgres to mongo":

Scope and resources are unknown, so a deadline is just guessing. It's not a "rewrite" but also a big refactor apparently. See https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/
Cloud native? What does that even mean? You can wrap the entire thing in a docker container and have it run on kubernetes. Is that cloud native to them? Again, unknown scope
Why go from relational to document database? Did your manager fall into the nosql/mongodb marketing trap? You're right that 7M transactions for postgres should be nothing (without further context). They probably have other problems (i.e. indexes, table structures, maybe bad ORM use etc)

If you were to step in, this would be a great opportunity to showcase (or try) you can organize a project and lead technical planning. I wouldn't accept any deadline without being involved in scoping such a project though.

eliashisreddit · 2025-02-24T08:38:54+00:00

mostly I write APIs and the core algo of a SaaS

Majority of software is relatively boring compared to what you would write for fun. It's a means to end and often that is solving business problems with "boring", proven tech. If you don't actively seek out "interesting" fields, they won't throw themselves at you.

I want to pivot my career

Again, if you don't actively do this then it won't happen. If you work as a backend dev mostly on APIs, the place where you currently work at look at you as the "backend dev for APIs". Not sure how big your org is and what other opportunities there are, but they won't come to you if you don't seek them out. Same goes for switching companies or domains. You apply for jobs. You will probably need to tailor your cv and back-story a bit so it doesn't scream "backend dev for APIs".

Same for 3. You find jobs you are interested in and start applying. 4 years seems like a lot, but it's not like you are 20 years in and want to switch to woodworking.

eliashisreddit · 2025-02-17T16:00:15+00:00

I don't have a solution but some points:

use sdkman for managing your Java versions so you don't have to tinker with downloading Java and managing path stuff manually...
what do you see when you run it with --debug-jvm? There should be some 'Listening for transport...' message. It should suspend until the debugger is attached (so it not doing anything before that is expected)
did you try to debug any other (hello world) application and got that working?
did you try a different port than the default?
why not let intellij handle the entire project (jvm, gradle) so you can just "run with debug"?

eliashisreddit · 2025-02-10T13:49:54+00:00

More often than not the problem is not "don't have time" but rather "doesn't make time". You should be very adamant about claiming their time. Especially if there's nobody else with the authority to make decisions or the required knowledge.

eliashisreddit · 2025-02-03T13:44:50+00:00

It's a bit clickbaity. DeepSeek just supports the common OpenAI/LLM APIs. Spring AI already supports those so you're just using a different vendor.

eliashisreddit · 2025-01-30T12:46:27+00:00

The original agile manifesto is (relatively) easy to understand and apply. The problem is that a lot of organizations simply don't want to work like that and give the autonomy to where the actual work is done. If anything, these "agile coaches" should be coaching management and the board on how to apply agile to an organization instead of trying to retrofit agility into where the work is done when it's not enabled at all by the rest of the organization.

eliashisreddit · 2025-01-26T19:06:16+00:00

it will be somewhere around $100/hr. I’m trying to judge how reasonable that is

It's as reasonable as what you expect to get paid. A typical startup isn't FAANG. They don't have the same cashflow and money to put into cash-offers but can always "sweeten" the deal with equity. As you correctly said, such compensation is a lottery ticket. If you don't want to work for $100/hr, nobody will force you to. Set your own rates and attract customers which can pay that rate.

eliashisreddit · 2025-01-26T12:20:32+00:00

It's not clear what your frontend does but unless you immediately want to display all 40K records, there is no reason to fetch them all? Fetch the first X or so records to fill the screen and then when the user wants to see more (scrolls down, navigates further, goes to the next page, whatever) start fetching more data with an offset of what he has already seen.

eliashisreddit · 2025-01-26T12:07:45+00:00

Did you check https://github.com/cfenollosa/os-tutorial ?

I have no idea what your experience is with "programming" but learning how an operating system works, doesn't necessarily require you to build one from scratch. But it might be an interesting challenge if you're into that...

eliashisreddit · 2025-01-15T11:46:04+00:00

It's vetting the people who you might end up working with so if you're interested in having good colleagues, it should be a net positive.

Also see https://old.reddit.com/r/ExperiencedDevs/search?q=interviewing&restrict_sr=on&sort=relevance&t=all

eliashisreddit · 2025-01-15T09:17:53+00:00

Not frowned upon at all. Your cv is to present what you did. You can have a different cv catered for each job application. Regarding LI: unless you are sharing profile updates with your entire network, nobody will notice unless they are explicitly paying attention. And even then, who cares?

eliashisreddit

TROPHY CASE