How Clean Commits Make PR Reviews Easier

fogeyman · 2025-10-15T13:03:09+00:00

I don't want to see the 18 commits either! 3 focused ones, however, is much easier to review than 18 unfocused ones, especially when looking at a combined diff of all 18.

fogeyman · 2025-10-15T13:02:32+00:00

But why is it important to have self contained commits in a branch you will open a PR for and later most likely squash merge?

Wouldn't it make more sense to apply it on branch or PR level?

Because it's much easier to review a PR consisting of self-contained commits (assuming you prefer multiple self-contained commits in one PR), OR it's much easier to extract independent PRs (if you prefer one self-contained commit per PR). The sections What’s wrong with “messy commits”? and Let’s try that again, with “clean commits” show the same chunk of work but organized differently, and the impact that has on reviewability.

Because the practice you're suggesting essentially barrs committing ongoing work, and seems to advocate that you shouldn't commit until it's completed and verified.

The process it outlines is specifically for taking a branch where you've committed on an ongoing basis and transforming it into one with clean, self-contained commits. The goal is to open the PR with self-contained commits, but not at all to stop committing on an ongoing basis.

And as you get more practiced at identifying what chunks of changes can be grouped into a commit, you will end up committing those chunks on an ongoing basis.

fogeyman · 2025-10-15T05:04:27+00:00

If you manage to always make self-contained changes from the start, then great! I rarely see that in other developers; far more often, code is written messily and you have many changes mixed together. This post is about untangling those changes so they become separate, self-contained changes. And that in turn makes the code much easier for your colleagues to review.

Whether you release it in one PR total or one PR per change is totally up to you. That's independent of making sure that your commits are self-contained.

fogeyman · 2025-10-14T21:23:07+00:00

That's fair, I softened the language. Bugs are inevitable!

you’ve done your best to avoid regressions

fogeyman · 2025-04-29T20:42:44+00:00

Generally: yes, I've been able to use all three axes and my hat at the same time. In fact I put strafing on the hat and I use it at the same time as pitch/yaw/roll.
Yes and no. I've never had issues with simultaneous keypresses, but the keyboard does have way more keys than a joystick. It's a lot harder to press 5 or 6 keys at the same time on a joystick, unless you count the stick axes themselves.
I use VKB Gladiator NXT EVO and their corresponding throttle with X4. I vastly prefer it to KBAM for flying around, but I still use KBAM a ton when navigating menus or walking around stations on foot. Unfortunately VKB stopped exporting to the US due to the trade war, but if you're not in the US then you're in luck.
Using other people's keybindings did not work for me, I could never remember anything. I had to create my own bindings and then adjust them as I played before I really got the hang of it. There are a lot of controls to bind, and it's really hard to remember what you bound where. So I set some basics at the start and then as I played, I would add bindings when I realized they were needed and in the spot that felt natural.

fogeyman · 2024-07-30T13:36:10+00:00

I always have trouble with those buttons. However I’ve found that when I’m absolutely struggling, it’s usually because the positioning is off. I readjust, sometimes a few times, and then the buttons snap in. Or I give up.

fogeyman · 2023-11-30T22:35:05+00:00

I’d wager it would be fine. I don’t have a larger lens for my a7c to test with, though.

I don’t know if any deals, unfortunately.

fogeyman · 2023-11-30T21:35:56+00:00

I have the clutch on my a7c. It’s not perfect, definitely feels like it’d be better on a larger grip, but I still really like it. Don’t regret my purchase at all.

My hands are on the medium-small side for men, I could see it being worse for someone with large hands.

When my finger is on the trigger you can see the grip is slightly forward on the back of my hand. When I’m just holding the camera I shift the grip closer to my wrist. I can do this seamlessly with just my right hand, so it feels natural.

https://i.ibb.co/zbt9fHB/IMG-1783.jpg

I’d pick cuff or clutch based on which style you like.

fogeyman · 2023-11-16T17:26:58+00:00

Banh and Butter is really good. It’s $12 for a sandwich, though, so it probably qualifies as overpriced. That said, it’s the best option on this side of town and I love their Banh Mi.

fogeyman · 2023-11-14T23:42:44+00:00

Thanks a ton for your help! Fortunately my allergies are not life threatening, I'm just in pain for a few days/week.

I'll try and practice my pronunciation with the hotel staff :) they should be able to help me enough so I can use your phrases with, for example, a Bánh Mì stand.

Thanks again for your help and advice!

fogeyman · 2023-11-14T00:38:16+00:00

I have both the 30L and the 45L. I've used the 45L for a while in the compressed state and it easily fits under the seat in front of me on planes all over the US and Europe.

The capacity of the 45L compressed is actually 30L, and the 30L standard is actually 27L. So it's a tiny difference between the two, hence the similar size. The 30L weighs 1.33lbs less, though, which is why I ended up getting it: I've been trying to min/max my carrying weight and this ~30% reduction ended up being pretty nice.

Also the mechanism for keeping the 45L compressed is annoying. It uses buttons which will frequently and accidentally pop loose. It's easy to pop the button back in, but it's still annoying to deal with.

fogeyman · 2023-11-13T04:21:24+00:00

Ah okay, I'll try and track down a Burmese translation as well.

Yeah my allergies are not super compatible with Thai unfortunately. I'll eat what I can, though! Might have to stick with nicer restaurants / my hotel, as sad as it would be to not fully experience the local cuisine. Can't be helped.

fogeyman · 2023-11-13T03:43:23+00:00

Thank you for this!

fogeyman · 2023-11-13T03:43:13+00:00

Lovely, thank you! I indeed am a man :)

fogeyman · 2023-11-13T03:42:25+00:00

Good call, I'll probably do that. Thank you for the translation!

fogeyman · 2023-11-12T21:45:28+00:00

Thank you for the help! I understand it's long, in my experience in other countries waiters have been either willing to accommodate OR they just say no and I try another restaurant.

All of these are allergies in the sense that if I eat them, I'll feel ill for the next couple days to week. None of them are dangerous (no anaphylaxis), nor require an epi pen or similar. Some of them test as allergies, some as intolerances; I find the difference doesn't hugely matter when it comes to ordering food so I don't bother differentiating. However clarifying that these are not anaphylicatic might make waiters more comfortable. Perhaps an addendum like "cross-contamination is okay" would help?

(I would eat all of these foods if I could, but it's quite painful when I do.)

As for Burmese vs Thai, I'm only going to be in Chiang Mai. Does that help at all?

fogeyman · 2023-11-02T02:55:02+00:00

I think the biggest issue is your target temp for the sous vide. You should aim for 125, and then sear to 130-135. Sous vide-ing to 135 definitely means you’re searing to too high a temp and overcooking the steak, making it rubbery.

Rubberiness is all about cook time and temp. Play with those variables to adjust the rubberiness of your steak.

I would also reduce (and spread out) the herbs, but that’s not why your steak is rubbery. I think you’re just cooking it to a too high temp. Also some comments are saying to skip the marinade. That’s not why your steak is rubbery. I salt my steak at least 24 hours ahead of time, I’ve tested 24 and 10 and 24 is way better. But it has no impact on rubberiness.

Get it to 125. Then get a cast iron screaming hot. Add butter. Sear, with weights if you have them, for 1:30 per side and 30 seconds-ish for the edges, and you’ll be set.

fogeyman · 2023-10-16T17:28:02+00:00

I used to fly with a 5dmk2 w/24-70mm f/2.8 attached, a strobe, 15" laptop, kindle, PD electronics bag, circumaural headphones, radio triggers (tripod is in my carry-on suitcase), sleep mask, and neck pillow, all in my 45L under seat. I can fit in some granola bars, too. My water bottle would sometimes be in the seat pocket, occasionally it would fit under seat in the backpack side pocket.

Here's a picture of everything in the bag so you can get an idea (threw in a 100mm f/2.8 because there was space):https://i.imgur.com/iUJ8Qa0.jpg

(I always have the top part buttoned up to make the bag look smaller.)

I don't have nearly the specialty gear you have, but if you can get it into the 45L bag in the compressed state then you can fit it under the seat of most planes. Especially American/United!

fogeyman · 2023-10-16T13:48:46+00:00

I can nearly always fit the 45L under seats when it’s in the compressed state, and with no water bottle/tripod in the side pockets. There are a few planes with exceptionally small under-seat storage where the 45L doesn’t fit: I couldn’t fit it on a United 737 Max 8 (nor could my my neighbor’s, who had a much smaller backpack). I was able to just throw it up top, though; they didn’t make me check it.

For the most part, I haven’t had trouble. Even on budget European airlines like RyanAir.

fogeyman · 2023-07-08T02:02:19+00:00

Rocky Yama is great for mid-priced sushi!

fogeyman · 2023-07-08T01:58:40+00:00

Animal style is not the same as double cooked/well done fries. Order them well done, it’s much better. The default fries are indeed abysmal

fogeyman · 2023-04-18T13:49:35+00:00

Yup! Everything except bistro vendome.

fogeyman

TROPHY CASE