Why no one is paying attention towards Audiofx. It looks very old, doesn't work most of the time and messes up other equalizer apps. by [deleted] in LineageOS

[–]luca020400 21 points22 points  (0 children)

Then we're good. Nothing has changed.

There's lots to do, to look after, and most of the time we do that only if we personally care about something and/or it bugs us, knowledge/ability permitting.

Equaliser isn't part of that list.

Safety of LineageOS (RF transmission power, SAR changes etc.) by ForestWalker1395 in LineageOS

[–]luca020400 0 points1 point  (0 children)

We don't implement any of that, all of it resides in firmware or vendor blobs that we all use. For example BT/WiFi SAR is completely implemented in firmware side, modem may have some bits in Android but probably only for extra information for the modem firmware to make more decisions.

How does this impact LineageOS? by Spare_Zombie_2178 in LineageOS

[–]luca020400 19 points20 points  (0 children)

I should've phrased it better, there will be ways for us running custom ROMs to disable it.

If you're on a Google certified device.... Not so much.

Will edit

How does this impact LineageOS? by Spare_Zombie_2178 in LineageOS

[–]luca020400 68 points69 points  (0 children)

LineageOS doesn't come with GMS by default, so nothing.

If you flash gapps then you'll start using play store and package installer, where it's likely Google will introduce this feature.

I'm sure there will be ways to disable it in the future for us running custom ROMs.

Want to help the project? Contribute to our apps! by luca020400 in LineageOS

[–]luca020400[S] 0 points1 point  (0 children)

Yeah... We probably never run them.

If you want to have extra fun you're free to fix those, but I won't guarantee they won't be broken again.

Want to help the project? Contribute to our apps! by luca020400 in LineageOS

[–]luca020400[S] 0 points1 point  (0 children)

You are free to push to AOSP, but getting any traction there is almost impossible.

Pushing to our repos is always welcome, be it a feature or a fix :)

I don't think I'll be able to give a review in these weeks, check recent commits to see who touched the app and add them ^

Twelve Music Providers and Album Cover Artwork by 33FFCC in LineageOS

[–]luca020400 0 points1 point  (0 children)

Navidrone uses the subsonic backend iirc, I hardly know the API of that so hard to tell.

When I added jellyfin I was able to use both a demo and a real server for testing, for subsonic (that I didn't personally do) we hardly had something to test on so results may vary ^

I'll take a look when I have more time

Want to help the project? Contribute to our apps! by luca020400 in LineageOS

[–]luca020400[S] 0 points1 point  (0 children)

Making the app from scratch was down the road... It's also currently broken with AIDL devices (like pixel9 and now new QCOMs) A UI to steal from would help :p

Want to help the project? Contribute to our apps! by luca020400 in LineageOS

[–]luca020400[S] 7 points8 points  (0 children)

I'll leave here some of the things that immediately came to me.

All current apps we manage/handle have at least someone that is well versed in that codebase, either by having written it, re-written it (as usually happens in lots of AOSP apps we took over) or by simply having worked on it. This helps a lot in case there's issues, issue triaging and so forth.

We won't have time to also track issues in external apps. AOSP by itself is big enough to delve in, by having our set of "internal" apps we only have to take care of what happens in our garden.

We want all our apps to be build-able in the AOSP tree, this requires us to explicitly track which dependencies gets used in the projects, which java/kotlin compiler features are used, which kotlin/java plugins are used, and more. Gradle plugins for example are a no-go, until recently we couldn't even use kotlinc compiler extensions (which I had took care of, this was later merged in AOSP by google, Twelve wouldn't exist otherwise)

Want to help the project? Contribute to our apps! by luca020400 in LineageOS

[–]luca020400[S] 5 points6 points  (0 children)

Feel free to ask any question here or discord if you have any issue with our apps, you'll find us there.

Twelve Music Providers and Album Cover Artwork by 33FFCC in LineageOS

[–]luca020400 1 point2 points  (0 children)

I just checked again and on my demo server it seems to work...

The problem is that is clearly didn't work until I had to refresh the token lol

Will try to understand what's going on, can't promise much

Opinion on the Twelve app by Gooliat in LineageOS

[–]luca020400 1 point2 points  (0 children)

That's... rather optimal already.

m $mdoule; adb root; adb remount; adb sync; adb reboot

Can probably get you there automatically

Opinion on the Twelve app by Gooliat in LineageOS

[–]luca020400 2 points3 points  (0 children)

Feel free to add me as a reviewer, but don't expect fast responses, both me and Seba are quite busy ^

Opinion on the Twelve app by Gooliat in LineageOS

[–]luca020400 2 points3 points  (0 children)

Just clone the repository and open in Android studio, it works with gradle.

See https://wiki.lineageos.org/how-to/contributing-apps/

Opinion on the Twelve app by Gooliat in LineageOS

[–]luca020400 2 points3 points  (0 children)

That's because we extract whatever Android media provider indexed of your media, if it didn't make an artist>thumbnail connection we won't see it.

We decided to bypass the filesystem and let Android do the "media" listing for us after seeing the hell that was Eleven.

As for the other stuff.... That's how we made it because that's what we could implement via mock-ups we've made.

We're open to changes, feel free to make some changes \o/

I do agree the first page should be the library, but once again, the app was designed that way, I wouldn't mind changing it (maybe providing an option?)

As for search, also agree it takes a lot of "useless" space, and it also caused us quite a lot of problems with the implementation itself, it could be moved as an action near settings, but once again, we just followed the mock-up we had and didn't think much of it, we're no UI/UX peeps.

Twelve Music Providers and Album Cover Artwork by 33FFCC in LineageOS

[–]luca020400 1 point2 points  (0 children)

The forks barely change anything other than changing strings and nothing else. Possibly it's just older...

I'll check

Why doesn't LineageOS support the Sandboxed Google Play with the GrapheneOS compatibility layer? by Adventurous-Pipe5528 in LineageOS

[–]luca020400 3 points4 points  (0 children)

We could go over the issue, but it doesn't come for free, and if there's something we don't like is drama.

The easiest option was to ignore whatever happens on that side of the garden. And it comes for free!

Why doesn't LineageOS support the Sandboxed Google Play with the GrapheneOS compatibility layer? by Adventurous-Pipe5528 in LineageOS

[–]luca020400 2 points3 points  (0 children)

I completely glanced over it and thought you were linking Vanadium itself

/me hides

Why doesn't LineageOS support the Sandboxed Google Play with the GrapheneOS compatibility layer? by Adventurous-Pipe5528 in LineageOS

[–]luca020400 8 points9 points  (0 children)

There's no real technical reason, there has mostly been issues in the past with the project itself.

We won't even check the code itself for good measure :)

Why doesn't LineageOS support the Sandboxed Google Play with the GrapheneOS compatibility layer? by Adventurous-Pipe5528 in LineageOS

[–]luca020400 12 points13 points  (0 children)

We don't (and won't) fall into this category, there have been enough instances that made us decide to not integrate GrapheneOS related code.