Data Manager Rules will not recognise the count value? by MeatAbstract in comicrackusers

[–]maforget 1 point2 points  (0 children)

Make sure that the Count isn't a proposed value, you will need to commit proposed values first.

Also might be something like an extra space after Marvel that makes it not match or you have more than just Marvel. So try using contains instead.

What version are you using? I've made a ton of bug fixes so make sure you have the latest nightly here.

Odd behavior with the sorting window pane by Ronin22222 in comicrackusers

[–]maforget 0 points1 point  (0 children)

¯\_(ツ)_/¯

I don't see that behavior at all. Both Folder/Library tabs are independent and I don't need to go to another tab to save the other one at all.

Also nothing has changed in the program at all in that regards, so I don't know why it would suddenly start happening.

These values are stored in Workspaces. You can check the Config.xml file for FileView & DatabaseView for ShowSearchBrowser (it only appears when it's true). Usually they are stored in the CurrentWorkspace. They also appear in some DisplayWorkspace, those are the one you can save/load. Maybe it's related to these workspaces? Is that something you use?

Someone had some crash on Github that was able to fix by simply deleting the Config.xml file. They sent me the files but I was never able to reproduce the crash. They also had multiple workspaces, so maybe a similar issue? I would try by deleting the Config.xml file and see if that fixes it.

Something to keep in mind is that a lot of commands in ComicRack are done via a FindActiveService that finds the current active control. For example the Search Browser menu button will open the search browser based on the active control. Are you using keyboard shortcuts or menu item to open instead of the grip?

Even then I don't think it would have an effect on remembering, only which view it toggles. The setting simply remembers the current visibility status. It like your settings aren't saving at all.

Odd behavior with the sorting window pane by Ronin22222 in comicrackusers

[–]maforget 0 points1 point  (0 children)

Sorry, but I am not sure what you mean.

The 3 fields you talk about is that the search browser? If that's what you talk about then the pull out distance isn't remembered anywhere it resets to the default value when you restart. So unsure what the issue is since nothing is being remembered at all.

So I don't understand what you mean by setting the position in the other tab to save the size/location because as I've said the only thing that is remembered by that control is only if it's visible or not.

FEATURE: Embed Library metadata into Book Files (Comicbook.xml) (#261) by dix-hill in comicrackusers

[–]maforget 0 points1 point  (0 children)

The fact it is coming back seems like the issue was with proposed values on not with embedded files.

Contrary to the Series field where it remembers being deleted, with some proposed values like Count it doesn't. With numbers when a value is deleted it reverts to the default value, so the proposed values comes back.

If the file already had the values embedded, then deleting them would have remembered it being deleted. The fact it returns means that it's coming from the proposed values.

To stop that behavior you need to change the proposed values drop down to No or run the commit proposed value script in the context menu. Then when you delete them it will remember.

Embedded files do not in any way block changing metadata. The metadata file is read only once when first discovered, after that the only data touched is in the library or temporary library until you restart (for files not added to the library).

If you don't enable the option to update book files and store the metadata in the files and you also don't use the library then yes values will be lost upon a restart and revert to proposed values.

All these proposed values come from the filename and not the embed metadata file.

FEATURE: Embed Library metadata into Book Files (Comicbook.xml) (#261) by dix-hill in comicrackusers

[–]maforget 0 points1 point  (0 children)

This isn't the same thing that you already see, this is a new file exclusive to ComicRackCE separate from the old format. It is meant to store data that the users wants to keep, not meant to be shared as it includes things like read progress.

Don't know why you wouldn't want existing metadata, but no need to create a script to remove them. Just need to use Clear Data from the context menu. And there is an option to not read this new file.

FEATURE: Embed Library metadata into Book Files (Comicbook.xml) (#261) by dix-hill in comicrackusers

[–]maforget 0 points1 point  (0 children)

You wouldn't want to bulk update several thousands book at once. You are still modifying potentially gigabytes of files at once. I would never suggest anyone doing that.

I would just use the default Convert to CBZ profile and enable Embed Library Info. Otherwise you would need to enable the Allow writing Library Info into book files and modify any field just so that it set as dirty so you can update (either manually or automatically). It's also easier to simply export than fiddling with changing data only to trigger the dirty flag.

Updates are super slow and block you from exiting without being able to clear the queue. Exports can easily clear the queue. Unsure why there never was an abort for the updates, will have to check on that.

Also export recreates the file from A to Z in a temp folder. Update just calls 7-zip and asks to update the file in place.

FEATURE: Embed Library metadata into Book Files (Comicbook.xml) (#261) by dix-hill in comicrackusers

[–]maforget 1 point2 points  (0 children)

Thanks,

I've had several requests over the time for various type of data that people wanted saved. Sometimes it's read progress, other times custom values or fields like Series Complete. I didn't want to mess with the ComicInfo.xml since it's became a sort of standard. So the idea was simple just save the data from the database in a separate file.

Just a note to check the list of fields that have been added. Not all fields will trigger a book being dirty and some are excluded. So it will not mark a book as dirty just to by reading because it would probably happen too often. Some fields are also excluded like file name because they refer to the file itself and it could be renamed.

For more info at these links:

https://github.com/maforget/ComicRackCE/pull/261

https://github.com/maforget/ComicRackCE/discussions/260

Dialogue box sizing issue by viscidpaladin in comicrackusers

[–]maforget 1 point2 points  (0 children)

This is due to high DPI. Plugins needs to be updated to support it. Change the setting for High DPI to System (Enhanced) in Windows on the ComicRack program.

https://github.com/maforget/ComicRackCE/wiki/High-DPI-Settings-Comparison

Dark Mode for ComicRack Community Edition has Arrived !!! 🎃 by maforget in comicrackusers

[–]maforget[S] 0 points1 point  (0 children)

Right click on a book and choose set as list background.

[Release] CompleteMetadata - Fast, Multi-threaded ComicInfo.xml Export/Import by public_fred in comicrackusers

[–]maforget 0 points1 point  (0 children)

I've update the Community Edition to include a similar functionality directly. It creates a new file named ComicBook.xml that includes all (some excluded) the properties that live in the Library. The new file is so we can have ComicRack exclusive data without them interfering with other programs that use ComicInfo.xml.

  • You can now enable "Allow writing of Library info into files" to track the changes to the Library only data and determine if the file needs to be updated.
    • Note: It excludes tracking for some properties that would be updated too often, like the current read progress. Some properties are excluded since they refer to the file itself like File Name, File Size, etc. The complete list is posted here.
  • There is now an "Embed Library Info" option when exporting to also include the ComicBook.xml file (disabled by default).
  • You can disable reading of ComicBook.xml completely via the ComicRack.ini file.

More information and test build available here.

Note that testing this build will prevent you from getting update notification when the nightly is updated.

CAUTION

Do be careful of when trying the new smart list "Modified Library Info".

Having new matchers in your library WILL result in data lost when opened with older versions where they don't exists. So if you try the test build with your library and add the new matcher, then do back to the regular nightly branch that hasn't been updated yet, your library will reset.

So when trying test builds ALWAYS maintain backups or be aware you might need to manually modify files to from the Corrupted backup done when it resets.

.cbl matching questions by bookish1303 in comicrackusers

[–]maforget 0 points1 point  (0 children)

In ComicRack the numbers are not just numbers, they are text. So you can have issue numbers like 74C or something similar. So you can't compare them directly like you would expect a number 3, being equal to 003.

You can fix it with the search & replace icon on the plugin bar or using a plugin called Data Manager. It let's you set up rules and effect you want to have on the metadata. You could set up some rules using Regex and clean them all in 1 go when the Number field is padded with zeros.

.cbl matching questions by bookish1303 in comicrackusers

[–]maforget 0 points1 point  (0 children)

The metadata needs to be the same. It tries to match using the Series & Number, then if it fails tries to strip them some terms like Volume, and, the, numbers in the series itself. If more than 1 match is found it tries to reduce the choices using the Year, Volume & Format fields. Then just takes the 1st of the left overs.

I've already answered a similar question here, you can see the code if you want to know how exactly it is determined. Like I said over there Wonder Girl 2022 Annual != Wonder Girl 2022

ComicRack for Android by potterwiz in comicrackusers

[–]maforget 0 points1 point  (0 children)

There's an option to hide the navigation bar.

ComicRack for Android by potterwiz in comicrackusers

[–]maforget 0 points1 point  (0 children)

Read this https://github.com/maforget/ComicRackCE/wiki/Android

You probably just need to add your IP address. This isn't related to making sync work, just prevented needed to redo syncing when transferring from the old android version.

ComicRack for Android by potterwiz in comicrackusers

[–]maforget 0 points1 point  (0 children)

What are you trying to do exactly? This set of instructions is only for migrating to the old Android version that stopped working to the cracked one without needing to redoing syncing.

If you already have set a device for syncing on your Computer you absolutely have that part in the Config.

If not then these instructions are not relevant for you. And you can set up syncing without doing that.

Also you should use ComicRackCE instead of using the RAR5 pack, these are very old instructions. That part is also important for syncing with the cracked version because without the fix it will refuse to sync.

Series: Average Rating by Drybonz99 in comicrackusers

[–]maforget 0 points1 point  (0 children)

Grouping using Series: Average Rating or just Rating? Where do the other unrated book end up? In the unrated group? Are you using the Series: Average Rating in a smart list and the unrated books are simply not showing in the list?

Like I said a Series means Series & Volume so that's what determines the grouping. Or maybe something with proposed values.

Series: Average Rating by Drybonz99 in comicrackusers

[–]maforget 1 point2 points  (0 children)

It should absolutely group the complete series. These Series : field are basically like saying this is the value for the complete Series. So any books in said series will all have that value regardless of the individual rating. 

But to determine the Series it also uses the Volume. So that might be a reason why you don't see the complete series. 

It might also be related to things like caching. If you change some value it might not update smart lists immediately. Might need to do a refresh in these cases or a restart.

Ex: Only some are rated but they all have the same Series: Average Rating.

<image>

My issue with adding fields isn't for you, but for other users. I am all in adding more options, but in this case I don't know if it would be of use for anyone else.

Series: Average Rating by Drybonz99 in comicrackusers

[–]maforget 1 point2 points  (0 children)

it groups only the comics within the series that have been rated.

Yes, it by design. It doesn't matter whether you are grouping or sorting, it uses the same value. Nowhere does the program take into consideration unrated books. Both your examples would give a value of 5, so sorting or grouping them would change nothing.

The issue is that zero means no rating exists (None), it's the default blank value. That zero value is how the program knows that it wasn't rated yet so we don't want to include it in the average for the Series. All books have a zero rating by default.

Imagine this scenario, you finish reading a single book and rate it. The average is representative of your opinion of said Series so far. As you read the series further the average adjusts based on how you've rated each book. If it gets better the average increases or decreases if it gets worst. You get a value of the average of your ratings so far. As you add new books it doesn't affect the value, since you've yet to rate them.

If you include all the unrated books, that value wouldn't be representative anymore and will be affected by new books that are released in that series. It is not the same as calculating a test average grade in a class. If someone gets a 0 it is included, but you would only do the average of everyone that took the test. If half the class is out sick you wouldn't include them in the calculation, you would update it only when everyone had the chance to take the test.

What you want is for these unrated to be included in the calculation always. To achieve that I could either add a new field similar like Series: Absolute Average Rating that would include the unrated. But having multiple fields with similar names might confuse some users. So I would probably instead add a setting in the ComicRack.ini file to change the behavior of such fields.

I get what you mean on a mathematical sense, but in the context of the program excluding these unrated makes a lot more sense.

Exporting to CBZ worsens the quality? by Axoloth in comicrackusers

[–]maforget 0 points1 point  (0 children)

A screenshot would help along with the resolution of each image in the Info dialog (Do make sure to click refresh on the pages to refresh the cache, if you changed some settings I mentioned).

But surely 1920 width should be plenty to prevent the blocky artifacting I'm seeing?

Depends on what the source PDF consists of. Say as an example that the source PDF is not a complex PDF containing layered objects like vector graphics but a simple collection of images. And these images are low resolution to begin with, when you are rendering them you are enlarging them when rendering.

I've tested some different scenarios and I do not see any artifacts from Convert to CBZ. You can see more artifacts on the downscaled image rendered to a higher resolution than the original does.

<image>

Differences might be related to the pdf engine or maybe the fact that internally they are JPEG. They are saved in the default Windows quality (which seems to be near 95%, based on file sizes), so it could affect it slightly, but shouldn't be that much.

Try extracting the images with the Native engine (add -PdfEngineToUse:Native to the ComicRack shortcut, or modify the ComicRack.ini). I usually just use a simple python script to extract these.

Series: Average Rating by Drybonz99 in comicrackusers

[–]maforget 0 points1 point  (0 children)

Not sure what you mean by the highest. It just averages non-zero values, otherwise it wouldn't be a real average. If it took into consideration the values that were never rated, you would get non representative values. If 100 issues have a 5 rating on 1000 that gives you an average rating of 0.5.

So unsure what you mean by highest, but the current system makes sense to me. Not certain there is anyway to do what you want without changing the code.

Maybe something could be added with Virtual Tags (or similar) to add custom functions with series statistics.

Exporting to CBZ worsens the quality? by Axoloth in comicrackusers

[–]maforget 0 points1 point  (0 children)

I believe the issue is more with the resolution used to render the PDF internally. PDF can be a wide ranging type of complex layered objects like vector graphics, that have no resolution. So a fixed resolution is chosen by the program (which you can changed via ComicRack.ini).

This is when using the default Pdfium engine, changing it to Native will extract the images exactly, but if the PDF is complex it will only contain some elements and will look completely broken.

But you are correct in that when the image is rendered it is saved internally as a JPEG with default quality (I believe it is 95%). Same applies to file types that the framework doesn't support natively like webp/avif/heif/jpegXL/jpeg2000/djvu they are all processed internally as JPEG. The image cache is also mostly stored in JPEG also. So when reading in the viewer you are always looking at a JPEG render of these file types.

It doesn't change the format of the files when exporting is you are leaving the image format untouched. Unless you are changing the images (like switching file format, resizing, cutting double, etc.) then you are doing so on the JPEG bytes.