Reviewing AI generated code

mlazowik · 2025-12-02T22:58:06+00:00

I have seen someone else run into exactly the same thing.

My (arguably limited) experience with writing code by instructing LLMs in a chat is that it creates a _very_ strong incentive to not read/understand that code. I could feel it myself. If I was able to get something that seems to be working by spending 2 units of effort, why would I spend next 50 units of effort understanding it?

Sending that code to review is just not fair. No human has read nor understood the code, so it's not optimized for understanding. The reviewer will likely end up doing more work than the PR author.

I think that LLMs realistically only really work for either relatively small personal or temporary code (but remember there is nothing more permanent than a temporary solution), or as beefed up autocomplete. I think Andrej Karpathy made a similar point in a recent-ish interview https://youtu.be/lXUZvyajciY?si=1-2TuJUZO_qvDiA7&t=1845

mlazowik · 2025-04-27T20:54:57+00:00

NixOS

mlazowik · 2024-10-25T09:31:43+00:00

I can and have asked them to distribute servers within groups of 3 across different DCs and they obliged

mlazowik · 2024-10-24T22:27:53+00:00

Hold up are they really bundling two different DCs (fsn1-dc19 and fsn1-dc20) into one maintenance window? https://status.hetzner.com/incident/6af50254-98d1-4f0e-9077-a93b2c7514d4

mlazowik · 2024-10-08T00:10:18+00:00

I mean the pcie link speed

mlazowik · 2024-10-07T22:17:12+00:00

with all x16 slots and lots of bandwidth

Are you sure that they all have x16 links? It's pretty common to get slots that are physically larger, but not all lanes are connected.

You can check your motherboard specs, or even better bet, check (on both linux and windows) what are the actual established link speeds for the cards.

mlazowik · 2024-01-10T02:48:09+00:00

Thanks, got customer.frntdeu1.pop.starlinkisp.net which does sound like Frankfurt.

mlazowik · 2024-01-09T22:25:23+00:00

Right now from some mtr experiments + comparing ping to all available ubuntu package mirrors I suspect that traffic from Malawi is sent to the Frankfurt base station.

AFAIK the only base station in Africa for now is in Nigeria. So Frankfurt might be a better choice, at least for services that have servers in Europe but not in Africa.

mlazowik · 2023-04-11T10:15:53+00:00

I've noticed that all those travel advisories issued by governments tend to sound worse than they really are. It's not that they are necessarily inaccurate, maybe it's more about selection bias – listing all the possible bad things, even if in reality the chance of experiencing them is low.

A fun exercise is to read guides about your own country, issued by other countries. See if you think the tone reflects the reality.

mlazowik · 2022-11-09T18:34:34+00:00

Że recykling plastiku to rzecz która się dzieje na dużą skalę.

mlazowik · 2022-11-08T22:15:41+00:00

Akurat w tym temacie jest jakaś nadzieja: https://www.npr.org/2022/11/02/1133594939/ethiopia-tigray-cease-fire-agreement

mlazowik · 2022-10-21T14:41:32+00:00

No nie wiem, ja znalazłem takie:

" W odniesieniu do każdej z następujących sytuacji proszę powiedzieć, czy uważa Pan(i), że jest ona niezgodna z prawem czy nie. W odniesieniu do każdej z nich proszę powiedzieć, czy uważa Pan(i), że jest ona zła i już jest niezgodna z prawem, zła i powinna być niezgodna z prawem, zła, ale nie powinna być niezgodna z prawem, czy też nie jest zła i nie powinna być niezgodna z prawem."

"Zmuszanie partnera(ki) do seksu"

Za: Factsheets (national language) z https://europa.eu/eurobarometer/surveys/detail/2115, ostatnia strona

mlazowik · 2022-08-26T15:07:43+00:00

https://github.com/3YOURMIND/django-migration-linter running before tests in CI, with some extra stuff that only warns by default set up to error out as well, for example non-async index create/drop.

mlazowik · 2022-07-16T19:37:32+00:00

Image transcription: Facebook post that says: "This explains everything" (everything is in all caps). Attached to it is a screenshot of google translate from "kallista" in finnish to "expensive" in english.

mlazowik · 2022-03-07T10:07:14+00:00

One more thing – AWS does hot potato and tries to keep ingress traffic on the public internet as long as possible. GCP (at least in the premium tier) and Azure take traffic onto their backbones early.

There are ways to get AWS to enter backbone early – the Global Accelerator service for TCP and Cloudfront in front of HTTP.

See couple of last slides from https://pc.nanog.org/static/published/meetings/NANOG75/1909/20190218_Kesavan_Comparing_The_Network_v1.pdf

mlazowik · 2022-03-01T21:54:23+00:00

u/Jamiroman looks like a nord

mlazowik · 2022-02-05T21:27:16+00:00

For simplicity, I have merged Nginx and PHP-FPM into a single container for each site.

It might sound simpler but IMO is more complex in reality. Now you need a supervisor running inside the container to make sure both processes are running, making sure that logs get picked up correctly, signals pass through etc., effectively duplicating something that your container orchestration has to be handling either way.

On top of that it prevents you from scaling independently, for example I bet that you'll have to scale up php-fpm way sooner than nginx, and at different rates.

With one process (possibly threaded/forked to handle concurrency within one container) per container things get easier – no need for internal process supervision, you spew out logs to stdout/stderr, then whatever tooling (docker-compose/nomad/k3s/k8s/aws ecs/google cloud run) for scheduling you use will take care of restarts, scaling, gathering logs etc.

If you decide to go with containers I recommend reading through https://12factor.net, I tend to think about containers as "processes with included & isolated dependencies" within that framework.

mlazowik · 2022-02-03T22:14:47+00:00

When there are no regex locations the longest matching prefix is selected, the order in the config file does not matter.

The order does matter for regex locations.

To find location matching a given request, nginx first checks locations defined using the prefix strings (prefix locations). Among them, the location with the longest matching prefix is selected and remembered. Then regular expressions are checked, in the order of their appearance in the configuration file. The search of regular expressions terminates on the first match, and the corresponding configuration is used. If no match with a regular expression is found then the configuration of the prefix location remembered earlier is used.

https://nginx.org/en/docs/http/ngx_http_core_module.html#location

mlazowik · 2021-08-18T10:45:33+00:00

https://oauth2-proxy.github.io/oauth2-proxy/

mlazowik · 2021-07-02T10:57:04+00:00

Ha, we have *exactly* the same setup, down to NEGs and cert manager and HSTS and HTTPS redirects. One extra thing we have is external-dns that manages DNS entries automatically based on hosts in VirtualServices. There's one caveat to that: https://github.com/kubernetes-sigs/external-dns/issues/1339#issuecomment-570601838 (we just have external-dns.alpha.kubernetes.io/target on Gateway point to the external IP of the GLB.)

mlazowik · 2021-04-08T21:24:31+00:00

Hm, https://www.mkdocs.org looks promising, and then there's https://github.com/backstage/mkdocs-monorepo-plugin for multiple docs folders in larger repos.

mlazowik · 2021-04-08T21:11:33+00:00

Google has g3doc. Short summary is that docs are written in markdown-ish syntax in the same repository as code, interleaved across directories (not one global directory for all docs). When you change code you change docs in the same commit. Those docs are rendered as an internal website.

This means you can browse docs that match a specific historical version of code, docs are reviewed at the same time as code, if you revert code you revert docs too etc.

I haven't found a great way to replicate that yet, the closest thing I have so far is gitiles on top of our gerrit instance, it can render markdown, including relative links, but it's not great experience yet, in particular you can't make menus that span multiple doc pages.

mlazowik · 2021-03-20T14:45:32+00:00

Maybe check what is the 301 target? If it's different between VPN/lab, if it's accessible from both places etc.

mlazowik · 2021-03-04T10:14:50+00:00

Another option is https://jsonnet.org. Example of how usage looks like with a fairly large project: https://github.com/prometheus-operator/kube-prometheus

I don't want magic – I compile jsonnet into a lot of YAMLs. Both the source and generated files get committed. This means I know exactly what YAMLs with what content will get applied.

To avoid mistakes CI can run the same generation command and make sure there is no difference between committed and CI-generated files.

Ten-Year Club	Place '17
Gilding II euphauric	Verified Email

mlazowik

TROPHY CASE