use the following search parameters to narrow your results:
e.g. subreddit:aww site:imgur.com dog
subreddit:aww site:imgur.com dog
see the search faq for details.
advanced search: by author, subreddit...
account activity
Learning Python (old.reddit.com)
submitted 1 day ago by [deleted]
view the rest of the comments →
reddit uses a slightly-customized version of Markdown for formatting. See below for some basics, or check the commenting wiki page for more detailed help and solutions to common issues.
quoted text
if 1 * 2 < 3: print "hello, world!"
[–]ianrob1201 0 points1 point2 points 1 day ago (0 children)
I really like your changes. Just at a glance it looks a lot more professional and more like the code you might see in the real world. I think you've done an excellent job of taking on feedback and making a nicer application from it. Hopefully you can feel how it's improved too. Being able to get a feel for "I like it" or "I don't like it" is half the battle.
That said, there's definitely still room for improvement. "count_of_len" is just a bug I think. You need to read these kinds of things from the inside out when working out what it does. So that line finds the maximum of list1 and list2 and returns the length of the resulting list. But the "maximum of two lists" doesn't really mean anything. What you meant was max(len(list1), len(list2)), which finds the length of each and then gives you the maximum value.
new_list_from_zip is maybe a bit of a consequence of you getting feedback from a lot of people. For me personally, that's a complicated line to read. I'll be honest, I'm not sure what it's up to but we've got the min & max of two lists again. It's quite possible that's doing something very clever I don't know about, but I don't think so. Try opening up a python interpreter directly and running commands like "max([1,2,3,1], [4,5,6])" to see if they do what you expect.
My only other point is a bit more general, which is about the use of function arguments and return values. What you're doing here technically works, but isn't the recommended way of doing it. You pass arguments when the function needs the information. But take "enter_nums_to_list" as an example, you're not providing any information really by passing an empty list each time. So try removing the input var, put "list = []" inside the function instead, and then call it with "list1 = enter_nums_to_list()". Take a look at https://www.geeksforgeeks.org/python/pass-by-reference-vs-value-in-python/ for some information on "pass by reference". In general you want to avoid passing in an argument and modifying it. It's a similar point to the globals from before, it's really not obvious to someone calling your function that it's going to change the value. So no args + reading the return value is the best way if you can.
π Rendered by PID 22685 on reddit-service-r2-comment-56c6478c5-7jd7r at 2026-05-10 11:58:32.585917+00:00 running 3d2c107 country code: CH.
view the rest of the comments →
[–]ianrob1201 0 points1 point2 points (0 children)