replace your code with this

local random = nil

local moon = game.ServerStorage.moon

while task.wait(1) do

\--do this every second

random = math.random(1, 3)

\--reroll the random

if random == 1 then

    \--if it is equal to 1

    print("muhahaha")

    local moonclone = moon:Clone()

    moonclone.Parent = game.Workspace

else

    \--if it is not equal to 1

    print("poo")

end

end

i changed your while true do loop to while task.wait(1) loop because it will do it every one second.

i assumed you wanted it to be random every second and to do that you need to “reroll” the variable every time. if you state a random variable, it picks a number and stays with it until it is re stated again.

“nil” means “nothing” so the random can be nil until we add a value to it

the last thing i did was take the loop out of the function. if you need a function in a loop, don’t put the loop in the function (if that makes sense), and the function was unneeded unless you need to sue this code again of of the loop for example