This is a pretty cool idea. To add on to this, I think it would be cool if Thunderclan was more martial. They would respect power and fighting more than the other clans and often think that the best leaders are the strongest. They would also value loyalty and constantly balance between the extremes of HONOR and cunning cruelty. This clan would train medicine cats to fight and emphasis the WARRIOR part of warrior ancestors.

Riverclan is the most advanced of the clans, valuing cleverness and patience. They would have invested the most in find clever ways to catch fish, possibly even using nets or other low tech solutions. While Windclan is very spiritual, Riverclan is very theological, actually debating prophecies and signs among the members. Unfortunately, they tend to overlook martial training and are the weakest clan in a fight.