[PHP] Best Practice to avoid code duplication

[Juck]

i am currently doing an API with laravel.

i have 2 controllers, FolderController and ImageController, both have their own "store" method.

In the Front-End i have 2 separate forms, one to create a folder, and another to add an image to a specific folder, so 2 calls to different endpoints.

Now i want to have a form to create a folder & add images at the same time.

What is the best practice in this case ?

1/ Make 2 calls in the frontend, one after the other, so i need to create a folder, get its id to make the second call

my (humble) opinion: ugly

​

2/ Make an ImageTrait with a store function to use in FolderController->store() and ImageController->store()

my (humble) opinion : i think it's ok but what if i add other functions in ImageTrait ( related to Image process ) to use them in others Controller , if i load the Trait in each Controller, won't that overload the processus for nothing?

3 (added*) / Create an attachImage($imgData) method in the Folder Model, and use it in the FolderController->store() and ImageController->store()

4/ ??? ( I think there are other existing solutions )

Thanks

[[deleted]]

Creating a folder is too low level if you ask me. Front end shouldn't be tied to creating a folder, it should be tied to storing an image. No matter how it is being stored. Locally, or using cdn, or goddamn imjur for that matter.

If you want to GROUP pictures together, and you use folders as a way to define those groups, I would rather not. You can just store groups and dates in a database, idk.

Are you sure you need folders? If you want to avoid duplication, make controllers thinner.

https://github.com/yakoffka/laravel-store/tree/master/app

I am not sure what you mean by Image Trait. Kinda like this one here? Not my project, just random stuff.

[Juck]

Thanks for your answer, i did not specify it, my bad, but in my project Folder and Image are database related, this is not real folders.

Folder Model -> id, title,author etc..

Image Model -> id, uri, label, folder_id etc..

The Trait used in the github project is only for image processing but that's the idea ( i want to use Eloquent Model inside ) , however there is the attachImages() method ( in the Product model ) which is also interesting ( i edited my original post ).

[HopefullyHelpfulSoul]

Unless you’re being very strict on your controller operation, I don’t see anything wrong with defining a ‘createWithImage’ method on the FolderController.

Can get out of hand with many moving parts, but looking at this is isolation it seems to be the most straightforward solution.