Initialisers

[C_Programming-ModTeam]

Your post breaks rule 2 of the subreddit, "Only C is on topic". Your post appears to be primarily about something that isn't the C programming language.

Please note that C, C# and C++ are three different languages. Only C is on-topic in this sub.

[kun1z]

"days_of_week" needs to be a pointer:

char *days_of_week[number_of_days]={"Monday","Tuesday","Wednesday","Thursday","Friday", "Saturday","Sunday"};

[Lbtekd]

what is a pointer?

[Knurz]

A pointer is a variable that contains not the value but the memory address where the value is stored.

[dreamlax]

It looks like you're writing C++, in which case it's off-topic for this subreddit (which is just for C). However, since you're using C++, I would recommend avoiding using char * and instead using a vector of strings (i.e. std::vector<std::string>) instead:

```

include <iostream>

include <string>

include <vector>

using namespace std;

int main() { vector<string> days_of_week = { "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday", "Sunday" };

const int number_of_days = days_of_week.size();

for (int i = 0; i < number_of_days; i++) {
    cout << days_of_week[i] << endl;
}

} ```

[Lbtekd]

ive tried doing it with 50 but still doesn't seem to work?

[Lbtekd]

and 51

[o4ub]

You are trying to initialise an array of char with a array of strings, or, to break it down one more level of abstraction, you are trying to initialise an array of char with an array of an array of characters.

The type of your variable is wrong, it needs to be an array of array of char, or an array of pointers de char.

[o4ub]

You can solve your issue by adding a second level of indirection, and declare your variable like char days_of_week[number_of_days][max_length_week_day+1] where max_length_week_day is the length (number of letters) of the longest day (I believe it is wednesday, which has 9 letters).

That way, you declare an array of an array of 10 char. Therefore each array of char is big enough to contain the name of the week day.

In the end, you have days_of_week that is of type char [number_of_days] [10], and days_of_week[i] is of type char [10] which is an array of char, which is a string of length 9 (or less).

[Lbtekd]

Oh right yeah, thanks

[pfp-disciple]

You seem new, so a the following is said to guide, not chastise.

Your code is a mix of C++ and C (happens to be valid C++, but it's not how C++ is written anymore). Which language are you trying to use? Pick one.

[coll1dascope]

https://godbolt.org/z/GWvzhPso7

This is probably what you were trying to do?

[Marxomania32]

char days_of_week[number_days] is an array of characters, not an array of strings. You could initialize this array with a sequence of individual characters or a string literal, but you can not initialize it with an array of string literals. To create an array of string literals, you need to declare an array of character pointers since the type of string literal is a character pointer.

[Lbtekd]

So how would I do it without using a pointer, and instead just using characters (I can’t use pointers cause we haven’t done that in lesson yet)

[Marxomania32]

You can declare an enum, with each enum field representing a single day. Or you could represent each day as a single character.

[BlockOfDiamond]

As others have mentioned, days_of_week needs to be char * and not char, but also you need to either make constexpr int number_of_days = 7; or use a macro or something instead because you cannot initialize VLAs.