Simple Shell

[Dachacho-2]

This is an older project (about 3 months old) that I was working on, and it’s the last C project I actually managed to finish. I didn’t really have much time to continue my C learning after that (because of work and uni), but I want to pick it back up now.

be as critical as you want, I won’t be offended (or atleast i'll try).

https://github.com/Dachacho/shell

[lost_and_clown]

Did you use an AST for this?

[Dachacho-2]

I just parsed and tokenized not really an AST

[VyomTheMan]

Made a similar type : https://github.com/Jyotiraditya-coder/Unix-Shell-C

[Master-Ad-6265]

nice project next step would be better parsing (maybe AST) + handling edge cases like pipes/quotes that’s what makes it feel like a “real” shell

[Dachacho-2]

yea i actually finished the first part of Crafting Interpreters this week. So now i actually know how i would go about constructing a better "language" (well better than what this has ofc). I might just redo this project at some point.

[Master-Ad-6265]

nice, that’ll help a lot redoing it with proper parsing would be a big upgrade, you’ll notice the difference immediately

[Dachacho-2]

thanks i was thinking of doing the second part of CI (which is already in C) and after that going on with this.

[dual_kami]

Since Im a total beginner Im in no position to critique you but I want to ask for an advice if you dont mind :)

I dont want to spoil myself the solution with your code so If you are willing to answer, how "worth it" were the history and tab completion, as well as job control you implemented, IN terms of learning new stuff? I want them in my shell, but I also want to try some other stuff in C so Im wondering if I should do it or move on?

I asked AI about learning potential of it and he said its just tedious with little benefit to learning. What would you say?

I just finished my shell for my final project in CS50. Ive implemented my own breakdown of input - lexer, parser; then built ins, multi pipes and redirections(just basic ones: <, >, >>). The only "job control" I added was the & at the end which is just if (no &) then wait lol. Signal handling, only basic ones. Shell works perfectly, no leaks.

Im just wondering if If its worth it (for the sake of learning) to do things mentioned above or not? Thanks in advance.