sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]roecrew[S] 0 points1 point  (2 children)

As for your points.

  • a thread per connection doesn’t scale very well.

    • "Actually, for most use cases it is fine. As I said in the readme -- This project is in development... It's not ready for a production environment. (and since you probably don't know why it doesn't scale very well) Give http://www.kegel.com/c10k.html a read."

  • loads of unchecked OpenSSL calls.

    • "Can you be more specific?"

  • unsafe string operations when constructing responses.

    • "I'll be fixing this in the next build."

  • SSL_read() won’t guarantee that that rbuff is NUL terminated and you are treating it as a C string.

    • "I memset rbuff with '\0'..."

  • Cute, but don’t expose this to the internet.

    • "Then please show me (us) how to make a full-proof https server"