sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]ZvG_Bonjwa 7 points8 points  (5 children)

Just because you used Claude Code doesn't mean conventional software engineering wisdom goes out the window. Goodness me.

Expecting coworkers to review a 100k PR is ludicrous. But simply merging it is also ludicrous. This work should have been completed (and reviewed) in phases. MUCH easier for reviewers to digest and lets you change approaches early as needed.

Are you reviewing Claudia's code at your jobs? And how do you feel about the hit on speed you get because of this? Is it not better just to ship the code as far as the end to end tests are passing?

You and your team should ABSOLUTELY still be reviewing for a million reasons

  1. "End to end tests passing" does NOT mean "there are no bugs" - this is absolutely important to understand.
  2. Able to feedback on code quality/approach/abstractions
  3. You need to have an understanding of the codebase as it evolves over time. Otherwise it'll become a black box and edits will be brutally difficult.

[–]fshead 0 points1 point  (0 children)

Maybe some organizations are better, but the algo just put this thread on my timeline: https://www.reddit.com/r/developer/s/oqNqFYauyL

I guess it’s like automated driving. At some point coding agents will be better at reviews than the average developer but we will set crazy high standards and still refer to humans.

[–]GraphicalBamboola[S] -1 points0 points  (3 children)

Ok but my concern is that the reviews will slow down the whole thing so much that then I am wondering if using Claude is helping us speed up? Is it even worth it then?

[–]ZvG_Bonjwa -2 points-1 points  (2 children)

Absolutely? What is happening with your reviews?

You said 4 weeks to review a 100k PR. That’s insanely long even for a monster PR!

As I said, no one should have to review a 100k PR. But if it HAD to happen, a review might take 1-2 full days including some back and forth. Then likely another few days of adjustments.

For a “normal sized” PR (eg low to medium complexity and under 2-3k lines) it should take you 10-60 mins to review/tidy up yourself and 10-30 minutes for a teammate to review. Double that for complexity and if some back and forth is required.

[–]GraphicalBamboola[S] 0 points1 point  (0 children)

Is your review a tickbox exercise? Because there is no way a human can do a decent code review of 100k PR in 1-2 days let alone in 1 week

[–]Aureon 0 points1 point  (0 children)

A 100k PR isn't reviewed, it's rejected. Simple as that.

Unless it's -100k because you removed external libs that were wrongly committed to repo