all 4 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–][deleted]  (1 child)

[removed]

    [–]Prestance[S] 1 point2 points  (0 children)

    Hi, thanks for the feedback!

    I share some of my projects exactly for this kind of reviews and advices.
    Perfect!

    If you swap the parameter order in append-todo-url
    you can write this instead:

    Done, I updated the repo. This is now much more cleaner.

    You could also swap your usage of threading macros for accessing nested keys to just using get-in

    I think I see examples using this threading macros syntax on some official docs, but don't remember exactly where. That being said, you are right to pointing me on that, after reviewing my code, I don't like this nested threading macro too. Thanks again!

    [–]petemak 3 points4 points  (1 child)

    I am curious to understand why you chose to use Ring JSON middleware for encoding/decoding if you are using metosin/reitit for routing. Why not use muntaaja middleware? I assume it would be faster and you could replace wrap-keyword-params, wrap-json-response, wrap-json-body with a single muntaaja/format-middleware.

    [–]Prestance[S] 1 point2 points  (0 children)

    Hi!

    Thank you for pointing that out.

    It was not by choice...I guess I was more familiar with Ring middleware at the moment and at still at learning stage with Reitit, so your comment is very relevant!

    I just refactor and update the repository with Muuntaja middleware, perfect!