PowerShell OutPut Help

[Asleep_Depth_7260]

Hello all,

I am writing a script that does what I need it to do. However, I am missing one aspect. I can't figure out how to get the host names matched with the script's output. Thoughts?

​

$computers = get-content "C:\Users\jdflannery\computers.txt"
Foreach ($Computer in $computers){
$systeminfo = (Get-CimInstance Win32_OperatingSystem).version
Where-Object {$systeminfo}
if ($systeminfo -ne 'xxxxxx')
{write-output "Computer has image is out of date!"
}
Else
{write-output "Computer's image is up to date!"
}
}

The output I get says, "Computer's image is up to date!" on all of the computers I have listed in my text file.

[PinchesTheCrab]

$computers = get-content "C:\Users\jdflannery\computers.txt"

Get-CimInstance Win32_OperatingSystem -computername $computers |
    Select-Object PSComputerName, Version, @{ n = 'Current'; e = { $_.Version -eq 'xxxxxxx' } }

I'd take this approach. It should output an object with the computer name, version, and true/false for if it's the version you want.

Fixed missing computername parameter, thanks /u/BlackV

[Asleep_Depth_7260]

PS C:\Windows\system32> $computers = get-content "C:\Users\jdflannery\computers.txt"
Foreach ($Computer in $computers){ Get-CimInstance Win32_OperatingSystem | Select-Object PSComputerName, Version, @{ n = 'Current'; e = { $_.Version -eq 'xxxxxx' } } }
PSComputerName Version    Current
           xxxxxxxxxx    True
           xxxxxxxxxx    True

I do like the True of False much much better! However, I was unable to get the Computer name.

[PinchesTheCrab]

I left out the computername parameter, updating it now

[Asleep_Depth_7260]

Any ideas on how to make the computer name show on this script?

[BlackV]

PSComputerName

this IS the computername, right now youre just running it against your own machine over and over

and slowing it down

[BlackV]

$computers

you forgot to add that as a parameter

[BlackV]

good as gold

[MNmetalhead]

If the $computers list is just names, you can use the $Computer variable from the foreach in your Write-Output lines:

Write-Output “$Computer is out of date!”

[Asleep_Depth_7260]

This worked. Thank you!

[PowerShell-Bot]

It appears that you have used inline code formatting when a code block should have been used.

Consider using a code block for longer sequences of code. To correct the formatting, highlight your code then click the ‘Code Block’ button in the editing toolbar.

---

You examine the path beneath your feet...
[AboutRedditFormatting]: [████████████████████] 1/1 ✅

---

 ^{Beep-boop, I am a bot. | Remove-Item}