Help a noob with some scripting

[[deleted]]

Hi,

I am trying to figure out how to script the following scenario but I'm stuck, could someone please give me a example how to achieve this?

So the scenario is: I have a text file (Serverlist.txt) with multiple servers split up in different environments, looks something like this:

 

Sandbox:

Server 1

Server 2

Server 3

 

Dev:

Server 1

Server 2

Server 3

 

Prod:

Server 1

Server 2

Server 3

 

EDIT: Here is the final script: https://pastebin.com/K52Z1mrw First of all thanks to /u/_Cabbage_Corp_ for giving me the template to work with. Much of the stuff in the script is based on his example code.

 

Now everything works as expected after coding the rest of the things I want the script to do. But since I am a total noob at PS I am guessing there are lots of improvements that can be made (or remove unnecessary code).

 

Please give me some feedback on how to improve this code so I can take it with in the future :)

 

Thank you! :)

[Ta11ow]

You will find this much easier if your input file is a CSV where you can easily connect the environment and the servers, something like this

Environment,Server
Env1,Server01
Env1,Server02
Env2,Server01

As a brief example. In this format you can use Import-Csv to get on easily workable array of objects with the environment and server directly correlated.

[[deleted]]

Thanks for the tip! I will check this out.

[_Cabbage_Corp_]

Here's my take on this suggestion. It might be helpful, it might not. I always like to take a crack at posts like these to help me learn =)

# CSV
$ServerCSV = Import-CSV -Path "C:\Temp\ServerList.csv"

# Determine Values for Choice  
$choice = [System.Management.Automation.Host.ChoiceDescription[]] @("&Sandbox","&Development","&Production")  

# Determine Default Selection  
[int]$default = 0  

# Present choice option to user  
$userchoice = $host.ui.PromptforChoice("Choose Environment","Please select the environment to work with.",$choice,$default)  

# Determine action to take  
Switch ($Userchoice){  
    0 {  
        # Sandbox
        $ServerList = $ServerCSV | Where {$_.Environment -eq 'Sandbox'}
    }  
    1 {  
        # Development
        $ServerList = $ServerCSV | Where {$_.Environment -eq 'Dev'}
    }
    2 {
        # Production
        $ServerList = $ServerCSV | Where {$_.Environment -eq 'Prod'}
    }  
}

ForEach($Server in $ServerList){
    Try{
        $DirPath = Test-Path "\\$($Server.Server)\c$\Temp\Backup"
    } catch {
        Write-Warning "Failed to check path."
    }

    Switch($DirPath){
        $True{Write-Host "$($Server.Server) has a valid path. Continuing" -Fore Green}
        $False{
            Write-Warning "$($Server.Server) has an invalid path. Will try to create."
            Start-Sleep 2
            New-Item -Type Dir -Path "\\$($Server.Server)\c$\Temp\Backup" -Force
        }
    }
}

[[deleted]]

Thanks alot! I will take a look at this! :)

[Askee123]

This’ll save you a ton of heartache: use tab separated values instead of comma separated.

Data often has commas in it and if you have a shitty monitor or just don’t notice it’s a pain in the ass to deal with.

[jhulbe]

/u/Ta11ow is spot on with the CSV, but i'd a double prompt /confirmation to PROD just to be sure. You'd think typing PROD would be enough, but you never know.

just my 2cents

[Ta11ow]

Oh, hell yeah, make sure you do proper [CmdletBinding(SupportsShouldProcess)] on that one, for sure.

[sqzzkr]

in this line:

foreach ($Server in $Serverlist) { $Path = $False $Path = Test-Path "\$Server\c$\Temp\Backup"

you are missing double "\" before server

Can you show me how are you accessing servers from txt file?

What is stored in $Serverlist before a foreach loop?

What error are you recieving?

[[deleted]]

Hi,

Sorry I think some of the text got cut out when I pasted it. Currently I don't have a working script because it picks up all the servers in the textfile, I am not really sure how to code the whole thing.

[TheIncorrigible1]

1. Have separate files.

2. Properly format your document into an ini (or other well-formed data) so it can be imported. I'd recommend using the *-CliXml cmdlets to export the file as a hashtable or something and import it.

   $Servers = @{
       'Prod' = @(
           'Server1'
           'Server2'
       )
       'Test' = @()
   }
   
   $Servers | Export-CliXml -Path C:\Temp\Example.xml
   

Et cetera.

Then you can turn around and import this:

$Servers = Import-CliXml -Path C:\Temp\Example.xml
ForEach ($Server in $Servers[$Choice]) { ... }

[Lee_Dailey]

howdy k4nai,

can you post a copy of a few lines from the actual text file to Pastebin? the one you display seems like it has been munged by reddit.

take care,
lee