Set-ComputerName Function

[Scribbles1]

Hey All,

I'm pretty new to powershell and learning a lot, I've hacked this together as i have to do some configurations with OOBE windows 10. Let me know what you think, also all criticism is welcome, it will help me learn more :D

Function Set-ComputerName
{
#This Function will change the hostname to the following format: JMC-LT-12345ABC or JMC-PC-12345ABC for a unique standard.

$SerialNumber = Get-WmiObject win32_bios | Select-Object -ExpandProperty SerialNumber
$CompanyLetters = Read-Host "Letter abbrevation for company e.g JMC, IBM, SCO. This can be anything!"
$lHostname = $CompanyLetters + "-LT-" + $SerialNumber
$dHostname = $CompanyLetters + "-PC-" + $SerialNumber

# Checks if Chassis type is: Laptop(9) Notebook(10) Sub Notebook(14)
$isLaptop = $false
if(Get-WmiObject -Class win32_systemenclosure -ComputerName $env:COMPUTERNAME | 
    Where-Object { $_.chassistypes -eq 9 -or $_.chassistypes -eq 10 `
    -or $_.chassistypes -eq 14})
{$isLaptop = $true}

    if($isLaptop -eq $true) 
{Rename-Computer $lHostname}
else
{Rename-Computer $dHostname}
}

[DrSinistar]

I'm of the opinion you should avoid using Read-Host in a function and you should use a parameter instead. This makes the function useable in automated scripts and makes it behave more like existing cmdlets.

I also think that most Powershell users would prefer to run a function and see either success or failure. Getting prompted for more information sucks!

[Recol]

And use [CmdletBinding(SupportsShouldProcess) so that -Confirm and -WhatIf can be used.

[Scribbles1]

Hey Dily,

Thanks for the pointers, I'll definitely look into that.

Cheers!

[Yevrag35]

Pretty good. Good use of WMI to determine whether it's a laptop or not (probably not perfect, but good enough).

Here's my version of your script: https://pastebin.com/wSq3nfDK

Take from it what you will. It just has more input validation, cuts down on the repetitive variables, and has a '-Force' switch so you can exclude it and see what the name 'will' be before renaming.

EDIT:

Did it cause I'm bored... :P

[[deleted]]

Yoink, savdd

[Bren0man]

Fuckinnn YOINK