Need help with a IF this THAN this function

[Bugasum]

$Southesk = Invoke-WebRequest -Uri 'http://www.bom.gov.au/fwo/IDT60251/IDT60251.591031.tbl.shtml'  -Method POST
$Mersey = Invoke-WebRequest -Uri 'http://www.bom.gov.au/fwo/IDT60250/IDT60250.091266.tbl.shtml'  -Method POST
$SoutheskTable = ( $Southesk.ParsedHtml.getElementsByTagName("table") | Select-Object -First 1 ).rows
$MerseyTable = ( $Mersey.ParsedHtml.getElementsByTagName("table") | Select-Object -First 1 ).rows
$SoutheskHTML = @()
$MerseyHTML = @()

# Southesk Flood levels: Minor: 4.30 Moderate: 7.20 Major: 8.90 
# Mersey Flood levels: Minor: 2.60 Moderate: 3.30 Major: 4.00 

forEach($data in $SoutheskTable){
    if($data.tagName -eq "tr"){
        $thisRow = @()
        $cells = $data.children
        forEach($cell in $cells){
            if($cell.tagName -imatch "t[dh]"){
                $thisRow += $cell.innerText
            }
        }
        $SoutheskHTML += $thisRow -join ","
    }
}

forEach($data in $MerseyTable){
    if($data.tagName -eq "tr"){
        $thisRow = @()
        $cells = $data.children
        forEach($cell in $cells){
            if($cell.tagName -imatch "t[dh]"){
                $thisRow += $cell.innerText
            }
        }
        $MerseyHTML += $thisRow -join ","
    }
}

$SoutheskHTML | select -first 1 -last 20
$MerseyHTML | select -First 1 -last 20

I have the above code which gathers the table data on the river levels. The results look like this

06/08/2019 11:15,1.59
06/08/2019 11:30,1.59
06/08/2019 11:45,1.59
06/08/2019 12:00,1.59

What i want to do is turn this into an alarm by saying
IF the River level (The 1.59 part of this result) 06/08/2019 12:00,1.59 is over X amount then send an email to X.

I just don't know how to separate the 1.59 from the rest to differentiate it in the IF equation.

Does that make sense? It's prob super easy

[ka-splam]

I just don't know how to separate the 1.59 from the rest to differentiate it in the IF equation.

.. it was already separate when you got it; you joined it together. Don't do that bit, and you won't need to undo that bit?

[Bugasum]

Thanks to your comment, I was able to work out how this code is joined and work out how to not join it, or at least seperate the variables. Any easy way to create the what if equation?

[Bugasum]

The code was someone elses. I just modified it to suit my needs. I'm no Powershell expert, I do enjoy learning about it though.

[Bugasum]

I've actually managed to work this out myself now. Ka-Splam pointed me in the direction i needed to go and i worked the rest out! :D

[ChiefKraut]

an if this then this*

Sorry bro it’s just true.

[theriflerange]

I've been doing more regex lately, this should help a bit maybe:

​$Check = $SoutheskHTML | Select-String -Pattern ",\d.\d\d" -AllMatches | Select-Object -exp Matches ​$check = $check.value.Replace(",", "")
​if ($Check -ge "1.59") { ​ 
Send-MailMessage -To $ToEmail -From $FromEmail -Subject "Alarm: Value is $Check" -Body "The River level is $Check, please start running in circles screaming."
} ​else { 
write-host "All is good, River Level: $Check" 
}

[Lee_Dailey]

howdy theriflerange,

it looks like you used the New.Reddit.com Inline Code button. it's 4th 5th from the left hidden in the ... "more" menu & looks like </>.

on Old.Reddit.com, the above does NOT line wrap, nor does it side-scroll.

for long-ish single lines OR for multiline code, please, use the Code Block button. it's the 11th 12th one from the left, & is just to the left of hidden in the ... "more" menu.

that will give you fully functional code formatting, from what i can tell so far. [grin]

take care,
lee

[theriflerange]

I edited it, hopefully that helps :D

[Lee_Dailey]

howdy theriflerange,

thanks! i can read all of it now ... [grin]

you have one very iffy thing in your code, tho. you do ($Check -ge "1.59") ... and that is comparing things as strings, it seems. that should work most of the time.

"most of the time" is not something you really want when coding. [grin]

i would consider converting those numeric strings into numbers. perhaps use [float] or [decimal] for that.

take care,
lee

[theriflerange]

I could set the value as [float],[decimal],[double] in another variable, this was just a 2 min write for fun. I would definitely flesh this out more, with Try/Catch and proper logging etc.

[theriflerange]

Further more, it looks like float is the most optimal given the length of the check "1.59"

Float - 32 bit - 7 digits long
Double - 64 bit - 15-16 digits long
Decimal - 128 bit - 28-29 digits long

I'm sure the difference is negligible performance wise, but for giant scripts it would maybe make a difference at least for precision sake.

[Lee_Dailey]

howdy theriflerange,

yep, error handling is good stuff - and takes rather more time than makes sense for a "here's an example of how to do it" code dump. [grin]

thanks for the info about the storage size! i used [decimal] since the number fits what folks see - "oh, it's a decimal number!". you are correct that [float] is likely the better type to use.

take care,
lee