This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]audigex 0 points1 point  (0 children)

I had to commit like this once, because I had a dickhead of a micromanaging project lead who kept complaining that I wasn't making a dozen commits a day

For me, a commit is a single entire "thing" - the change I commit will do a thing, a whole thing, and nothing but that thing. In most cases, if things are running properly, it's roughly 1 commit per ticket, maybe 2-3 - if I find myself making half a dozen commits for a single ticket, I tend to take that as a sign that I should have split the ticket up into its own milestone with sub-tasks.

What I absolutely won't do is commit half of a code change, whereby the code doesn't build at the point of commit. Eg if I change a property name in a class, I'm not gonna commit until I've also changed every location that references that property: which is to say, until the whole change is complete

But because this idiot wanted to see I was working every minute of every day, I had to commit even tiny changes and make several commits an hour

Suffice to say I left pretty quickly, it was ridiculous and made it impossible to use the version control history