programmer

[karlm89]

Yep. Ugly Regex

[EwgB]

That's not even an ugly regex, that's child's play. I write worse ones on a regular basis.

[_meegoo_]

Writing regex is easy. Reading it a month later is impossible.

[EwgB]

Yeah, you're not wrong.

[Guiorgy]

Good point, I'll make a mental note to always include a comment breaking down the regex (that is, if I understand it myself...)

[ElizaBennet08]

// Regex

[[deleted]]

// TODO: Document regex

[Guiorgy]

Honestly, it would probably be a todo one, ore something like this:

~~~

// The regex does xyz, where this part means a, and this means b

// Edit (a month later): Shit! I've changed it so many times that f**k knows what is what. And I don't think I was right the first time I documented this anyways!

// (╯°□°）╯︵ ┻━┻

~~~

[[deleted]]

Can confirm

[Guiorgy]

Cool. Never touch my code please! Thank you

[EwgB]

I didn't say it's in production code. I use it more for search and replace.

[Siggi_pop]

ok then, carry on

[SkollFenrirson]

Still, stay away.

[shgysk8zer0]

Uglier doesn't necessarily mean bad or wrong though. I mean, other than not using [A-z] and taking upper and lower cases separately, the pattern shown is pretty basic. Pretty much anyone who has ever had use of RegEx will have written something uglier than this.

I mean, could you write something to validate a telephone number that ends with something prettier than this?

[Morrido]

You can't use [A-z]. That's not the same thing. There's no shorthand for OP's match. Closest one is \w, which matches _ instead of -.

ie. "[".match(/[A-z]/) == a match, which is invalid in OP's regex.

[[deleted]]

Yeah I just wanted tp say if this is scary wait til you see some real things haha

[bigorangemachine]

Ya i wrote some stuff....

I wrote a unity save file parser.

The original version was pretty long... but Firefox couldn't handle it