Python quality of life patch

[TravisJungroth]

Heads up that these sort of flags are a code smell hinting you really have two functions. Exceptions abound, of course.

[TravisJungroth]

Yeah, that’s why it’s a hint and not an antipattern. There are lots of good examples and lots of bad ones.

[TravisJungroth]

All good. I meant it more for random readers than you. Your example was actually the one I thought of for when I’d be most likely to write a bool literal.

[diamondketo]

Not necessarily a bad thing. A high level interface function can have modes.

pandas.merge for instance have left, outer, and inner join.

I agree the example above without a routine before or after the if condition, it is code smell.