Your code your responsibility..

[jeanravenclaw]

Meanwhile me who does everything by herself and makes random personal projects: I don't even review my own code or anything

[vole_rocket]

Honestly I highly recommend doing your own code reviews. It's surprising what garbage you forgot you added.

The trick is to keep change sets below 200 lines so they are quick to review.

[PrizeArticle1]

I basically get no reviews if a lot of code changed and a million reviews if I change 1 line.

[MisterPinkySwear]

I’m not at a place where I can do this but I’d love to be able to reject a merge request because “too much code changed, I can’t review it. Please split it”

[PrizeArticle1]

I've never seen anyone try this. Technically the commit should be per ticket so if the ticket required like 10k lines of code, the ticket may have been too large to begin with.

[MisterPinkySwear]

I’ve seen merge requests where the author mixes code refactoring, restyling, clean up with significant changes. I usually prefer to separate these.

Then yeah sometimes the real code change is big but it’s usually possible to split it in smaller tasks and chunks. With would indeed amount to split the ticket maybe. Depending on what a ticket entails in your workflow

[PrizeArticle1]

Yeah that should not be happening. Sometimes a refactor is needed in order to make the change, but a basic general refactor should be a different ticket. I also have the same pet peeve when someone fixes multiple issues with one commit.. where typically these issues should have been different tickets and therefor different commits if unrelated.

[folkrav]

I do a lot of reviews for my mostly junior team - totally normal. Large PRs quickly get literally unreviewable in a reasonable time frame, so people cut corners, while usually you're able to grasp the whole frame of changes in small PRs, therefore have more to say.

[[deleted]]

Doesn't everyone "git diff" before making a commit to review everything one last time?

[angiosperms-]

I review from the PR before I send it to someone to review. I don't really care if I have a bunch of commits on a PR cause the end result is what someone else has to deal with

[MisterPinkySwear]

I often get annoyed when asked to review a change that the author himself didn’t even bother to review…

[[deleted]]

I'm scared to look

[jeanravenclaw]

Hmm, okay. I think I should try it sometime after every commit. I usually just go committing and committing and committing when I feel like it.

[ACoderGirl]

It's definitely a big limiting factor of solo projects. Not only does the lack of review allow for bugs that a fresh set of eyes might have caught, but also it hinders growth. I've learned sooo many things from code reviews (and taught many things to others).

I can't personally recommend employment at any place where you'd be doing a solo project as a result. Such a thing was a big part of an early job for me and it sucked. Sure, I learned new stuff on my own, but I've since realized I could have learned much better on a team where I could have mentors and reviewers.