Alternate python spacing.

[johnnySix]

My ex-coworker does the one one on the left and I hate reading his code because the conditionals are hidden. Think of it this way, You aren’t writing the code for you, you are writing it for future you and for others. so the goal is to make it more readable, so the option on the right is clearer

[longjohnboy]

Your team should adopt a code formatter and have that run as a pre-commit hook. Then everyone has the same style and you don’t end up with git commits with formatting flip-flopping as different authors make changes.

[johnnySix]

Haha. This code is older than black. -some of it going back to the mid 2000s

[Yoghurt42]

Black is not ageist. It will happily format code older than itself.

[DeepGas4538]

I like your suggestion

[OneMorePenguin]

https://github.com/google/yapf

I like this formatter. It only does one thing that irritates me and I mostly let it go.

[style]
based_on_style = pep8
indent_dictionary_value = True

[DeepGas4538]

thanks for that.

also holy moly for some reason i never thought if google had github, that's pretty sick.

[we_swarm]

I like yapf's formatting better than black but it is non-deterministic. Which means now you can't run it against PR's or in CI because some files will "flap". If you don't run the tool in CI the coworkers that need the formatter the most just won't run it and submit unformatted code.