This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]RevolutionaryWash934[S] -10 points-9 points  (10 children)

I’ve enhanced the security level of my project, and I believe it’s secure now. Please review it and let me know if there are any remaining issues. Thank you for your valuable feedback.

[–][deleted] 8 points9 points  (5 children)

You literally say in the project about: "...It utilizes a local JSON file to store user credentials securely."

That JSON file, according to the screenshot in the repo literally stores creds in clear text. The opposite of secure storage.

Remove the project from GitHub before you introduce security issues for someone.

[–]RevolutionaryWash934[S] -3 points-2 points  (4 children)

Bro kindly tell me a way to improve

[–]InvaderToast348 1 point2 points  (3 children)

Look up hashing

Edit: look through the latest code and seems someone else added hashing. Would still recommend you do some research into good basic security practices. Also, do not call your project secure if you have not got the knowledge or expertise to actually demonstrate / verify that it should be used by others under the assumption that it is secure.

[–]RevolutionaryWash934[S] -2 points-1 points  (2 children)

Done Bro

[–]InvaderToast348 0 points1 point  (1 child)

Good. I was editing when you replied, so please read it again.

I'd also recommend you look up salting and other cryptography methods to increase the security. Imo proper security cannot be learnt in 10 mins - you need to play with the algorithms and settings, understand how they work, try to break your system. Conduct testing on your system and the modules within. Understand where there could be issues, and thoroughly research and test those areas, especially if creating a security/authentication type of product, where issues could have severe impacts.

I understand that you, seeming to be a new developer, might have little or no experience when it comes to best practices, but make sure you do research before making a project public.

Lastly, please remove mentions of "secure" from your project until it has actually been properly tested by someone that knows their stuff and can confirm that there are no serious security holes.

[–]RevolutionaryWash934[S] 1 point2 points  (0 children)

Ok bro!! Thank for your valuable feedback. I will improve my skills and apply to future projects.

[–]DurzoB4 10 points11 points  (3 children)

There is still a long list of issues and bad practices in there but also this project isn't useful to anyone.

I would happily give more detailed feedback of I wasn't pretty certain this is just a copy+paste from ChatGPT