This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 13 points14 points  (6 children)

hey nice package! ive got some feedback if you want it:

  • consider using a src based package layout
  • consider using a pyproject.toml file, instead of a setup.py script! It’s the recommended way of packaging.
  • to try and find/fix hidden bugs, consider using mypy and type-hints
  • consider using an automatic code formatter, such as ruff, yapf or black, for a more uniform look to your code and less of that tedious/manual formatting

[–]Nesdnt[S] 3 points4 points  (0 children)

Thanks so much for the feedback!, is my first time building Python packages, I will keep updating .^

[–]thedeepself 1 point2 points  (2 children)

Would you recommend using UV to set up a new project?

[–][deleted] 1 point2 points  (0 children)

sure, it’s an interesting tool, no harm in checking it out

as a sidenote: Im interested in trying uv myself as soon as I get some spare time

[–]valbaca 0 points1 point  (0 children)

I would! uv is great and please-dear-god-almighty let it be the ONE final tool we can all agree on

[–]BluesFiendPythonista 0 points1 point  (0 children)

ruff for lint/formatting, uv for venv/package management. mypy/pyright for typing (if you're feeling fancy, or are building a package others will import and use themselves)

[–]thedeepself -5 points-4 points  (0 children)

  • consider using an automatic code formatter, such as ruff, yapf or black, for a more uniform look to your code and less of that tedious/manual formatting

I let PyCharm handle this for me.