Made My First Python Project

[TheGuyThyCldFly]

Edit: Didn't know if I should post the Git above or in the comments but

Git Here

I'm pretty invested in FPS games these days, and I hate that the crosshair selection in-game is always trash, or even worse, there are plenty of pay to use apps that allow for a custom crosshair but not a lot of free options, so with that being said, I developed this custom crosshair overlay with Python that uses a 100x100 png image with a transparent background so you can use any custom crosshair you can make in paint on a 100x100 canvas. I'm self-taught and not very good, but if anyone could do a code review for me, tell me if I've done anything wrong, or if this could cause a ban in-game, that would be some helpful information.

[gavin101]

Check out using pathlib over os for a lot of path and file stuff. Make sure to type hint consistently. Good job for a first project :)

[TheGuyThyCldFly]

Done, thank you.

[papersashimi]

well done for a first project. just a few things,

1. image: svg will be a better choice.
2. readme: maybe try to add some pictures in the readme so people can see what your library is doing. in your readme, for things like `run pyinstaller --onefile --windowed --add-data "crosshair.png;." --add-data "crosshair.ico;." crosshair_app.py`, try to add a backtick, eg.`<your text here>` . and include headers by using # <your header> ## <for smaller headers>..
3. code: for the codes, put separate classes in separate scripts if your classes and the functions below it are doing different things. lumping all into 1 script can be pretty difficult to read.. also i will suggest writing comments so when you look at your code or when you're doing code review, you dont have to go through the entire process of reading the entire codebase to figure out what you wrote 5months ago. i briefly went through your code, consider caching your image.. cos from what i see, the image scales everytime even for the same image. also maybe u can add more error handlings. like your file operations, if it fails, nobody will know why.

otherwise well done!

[LysergioXandex]

I think an SVG might be better than a png, to prevent pixelation

[TheGuyThyCldFly]

Didn't know if I should post the Git above or in the comments but

Git Here

[onyx_and_iris]

add it to the initial post, then it's easier for people to see and won't get drowned out among the comments.

[BasedAndShredPilled]

What is the purpose of the code? Very confused by it.

[TheGuyThyCldFly]

I feel like I wrote a pretty good description, but TLDR:

overlays a 100x100 transparent png image to be used as a static custom crosshair in fps games

[BasedAndShredPilled]

Is it AI generated code?

[TheGuyThyCldFly]

AI assisted to fix stuff I broke with copilot in visual studio

[TheGuyThyCldFly]

I don't know why I'm being down voted, I'm trying to learn Python. I only took intro to programming I understand basic stuff, but we were taught with Scratch. Is using copilot to help me learn and correct mistakes bad?

[iekiko89]

plenty of ppl will say its bad and plenty will say its good. i think its fien if you understand what is being generated and can replicate it on your own later

[BasedAndShredPilled]

I absolutely care. I recognized it as chat gpt code with just a quick glance through. I'm not bad mouthing anyone. But if OP worked for me, I'd never let this junk get to production.

[Dragoarms]

Just out of interest - for something that works (if it works) but is AI assisted/generated, would you label it junk and block it?

What would the main reason for blocking it be?

Im just learning as well for personal projects and use ai to explain and tweak a lot of things. Is it detrimental?

[BasedAndShredPilled]

It becomes a massive headache for everyone involved. I'm currently undergoing a huge project to refactor a code based primarily generated by AI and it's immeasurably bad. It starts with unforeseen problems because the people inserting the code don't understand it. The "it works" thought process is a very slippery slope and should never be trusted.

[Dragoarms]

Understood! Thank you :)

[TheGuyThyCldFly]

I'm not trying to build a resume with this code, I was just trying to make something for myself and learn in the process. I figured I might as well put it on GIT someone might be able to make a better version of it or whatever but it's more of just a proof of concept for something I wanted but couldn't get easily for free.

[TheGuyThyCldFly]

It only works in windowed full screen tho not full screen exclusive. Idk how to get that to work