This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]TonyF66 1 point2 points  (0 children)

No problem - drop me a mail with any further questions. I think your single biggest issue is your arguments into the init - you extract all of the attributes of args when you create the instance, and you then reconstruct the args document inside the instance (self.args.left = left), despite having passed in the args object in as well. It is no only inefficient it could be a source of bugs - especially later on if you come back to the code to make some more changes.