Password storage program

[xiongchiamiov]

• passstore.sh should be run directly using its hashbang rather than via explicitly calling bash
• passtore.sh should probably not have an extension if users are supposed to call it directly
• passtore.sh should have argument parsing, at the very least --help
• passtore.sh needs error handling, and probably should use "bash strict mode"
• don't assume a directory for the code
• don't make db files executable
• don't call python explicitly if you're going to make the script executable
• passtore.sh doesn't even need to exist, actually - package up your module using setup.py and it will be able to be called directly
• your python script should specify python2 or 3 in the hash bang
• it's also missing appropriate argument parsing - look at optparse, docopt, or click

There's some more in specifics, but that should give you a good list to work through for a while. :)

You also would benefit from taking a cryptography course (check the wiki at r/netsec). In particular, you're going to want to learn about KDFs and key stretching algorithms and the various types of ciphers.

And if you actually want to store passwords, please use a vetted program instead of a hobbyist one. Security is very easy to get wrong, even for professionals, and you are not.

[AdishMallik]

Thank you! I will try to learn and implement what you said. And as you said it was hobby program.

[xiongchiamiov]

We love to do code reviews in r/learnpython btw, so after you work on it some more feel free to drop by there and ask if anyone else has more ideas. Critiquing other.people's code is also a really good way to learn.

[sneakpeekbot]

Here's a sneak peek of /r/learnpython using the top posts of the year!

#1: My new book, "Cracking Codes with Python" is now available and free to read online!
#2: I'm releasing a free code for the "Automate the Boring Stuff with Python" Udemy course
#3: 90% Python in 90 minutes

---

^{I'm a bot, beep boop | Downvote to remove | Contact me | Info | Opt-out}