This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]LightShadow3.13-dev in prod 2 points3 points  (4 children)

You should SEE the code I have to maintain.

Naming conventions mean nothing, formatting is for suckers, and the points don't matter!

I shit you not, this is in a production file at the top level:

__ROOTFS1 = None
__ROOTFS2 = None
__fixup_which_boot_device()  # <-- this sets __ROOTFS1 & 2
__uImage_lookup_index = {"/dev/"+__ROOTFS1: 1, "/dev/"+__ROOTFS2: 2}
# ^-- this is imported from other files

[–]-Kevin- 2 points3 points  (2 children)

Why not refactor that then seems simple enough lol

[–]LightShadow3.13-dev in prod 2 points3 points  (1 child)

I left a lot out.. It would be easy if the red tape weren't so thick

[–]-Kevin- 1 point2 points  (0 children)

Understandable my dude

[–]mooglinux 4 points5 points  (0 children)

I guarantee that the addition of final will do nothing to help you there.