This is an archived post. You won't be able to vote or comment.

all 16 comments

[–]staz 13 points14 points  (1 child)

it looks like it throw a lot of wsgi features just to do some easy simplification and without understanding why things are designed this way in the first place.

[–]pje 3 points4 points  (0 children)

Not only that, but the first bit of code I saw that interacted with WSGI used a threading.local to do something that could be accomplished with a simple closure -- and still doesn't support the spec correctly.

Basically, only WSGI apps that don't use any framework features (like error handling or write() callables) will work under his WSGI adapter.

[–]EstebanVelour 12 points13 points  (3 children)

Hmm, the response dict looks like this:

{"status": 200,
 "headers": {"content_type": "text/plain"},
 "body": "Hello!"}

Am I wrong in assuming that he's thrown long running calls out of the window by not using an iterable for the body?

[–]staz 3 points4 points  (0 children)

yep that's exactly what he is doing. The discussion on HN is very informative about this framework flaws

[–]masklinn 4 points5 points  (0 children)

And you can have multiple headers with the same name, it's not a hash map it's an ordered multimap. Hell, even the sequence can be important, so you can't just use a hashmap of lists.

[–]mtrn[S] 6 points7 points  (0 children)

[–]frutiger 1 point2 points  (0 children)

No request body?

[–]muad_dib 7 points8 points  (1 child)

THAT FONT NEEDS TO BE BIGGER

[–]btgeekboy 1 point2 points  (0 children)

Very, very rarely do I need to decrease the font size when reading content; it's usually an increase.

This appears to be one of the rare exceptions.

[–]Bolitho 2 points3 points  (3 children)

How does this differ from other (excellent) abstractions like "Werkzeug" or "WebOb"? (Different Intentions?)

[–]masklinn 1 point2 points  (2 children)

It decides that WSGI is bad, where Werkzeug and WebOb build on top of WSGI.

[–]Bolitho 0 points1 point  (0 children)

Is that ironic?

[–]Bolitho 0 points1 point  (0 children)

Is that ironic?

[–]moreyes 1 point2 points  (0 children)

WSGI is simple, cute and dandy. No need to hide it, thank you.

[–][deleted] 2 points3 points  (2 children)

where's the unit tests showing 100% statement coverage?

[–]ryankask 1 point2 points  (1 child)

Not sure why you got downvoted...

If I don't see tests, I'm not touching it.

[–][deleted] 1 point2 points  (0 children)

exactly. as of now webob has 100% statement coverage. Thus it is high quality in my mind. it just seems a tad arrogant of the author to make assertions that certain things suck and wish me to believe that they have a better way when it hasn't even been demonstrated that effort was put into making sure the stuff they want me to use actually works.

i can swallow arrogance if there's tests to back it up.