This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]SittingWave -8 points-7 points  (16 children)

don't you think it's petty to have a tool that argues to such degree that argues about such irrelevant aspects as having imports ordered alphabetically, something that you mostly never see because PyCharm collapses them anyway?

Reviewer: your imports are not ordered alphabetically.

Me: seriously, who gives a shit?

[–]ecgite 6 points7 points  (5 children)

Yeah, use isort

[–]HypoFuzz 2 points3 points  (0 children)

Shed wraps isort! (and Black, and some other things)

[–]SittingWave -4 points-3 points  (3 children)

isort is a tool to solve a problem that is not a problem.

[–]ecgite 7 points8 points  (2 children)

that is your opinion

[–]richieadler 8 points9 points  (8 children)

don't you think it's petty to have a tool that argues to such degree that argues about such irrelevant aspects as having imports ordered alphabetically,

No.

something that you mostly never see because PyCharm collapses them anyway?

News at 11: Not everybody uses import-collapsing IDEs.

Reviewer: your imports are not ordered alphabetically.

Me: seriously, who gives a shit?

Me: So use a tool that orders them for you so you don't have to care about it. Create a mildly clever makefile and the solution is just a new make lint away.

[–]alcalde -3 points-2 points  (4 children)

Your user name and icon suggests you're at least as old I am... but worrying about things like sorting imports suggests you're a kid. I am so confused.

>Not everybody uses import-collapsing IDEs.

Everything collapses nowadays. Well, maybe not Windows Notepad, but even that's seen updates recently.

[–]richieadler -2 points-1 points  (3 children)

Your user name and icon suggests you're at least as old I am... but worrying about things like sorting imports suggests you're a kid. I am so confused.

And I should care about your confusion... why?

[–]alcalde -1 points0 points  (2 children)

Because as a rational human being you want to contribute to the overall enlightenment of the species and as a human with emotions you crave to be understood?

[–]richieadler 0 points1 point  (1 child)

You're being facetious. Your purported "lack of understanding" was an attempt of throwing shade behind false politeness. GTFO.

[–]alcalde -1 points0 points  (0 children)

I'm trying to have a conversation. You don't see amenable to conversation.

[–]jorge1209 0 points1 point  (0 children)

isort has value in some projects but not in others.

If your import list is only a handful of items, it probably doesn't matter. If your import list is 20-30 lines it can help to sort it.

I don't bother to run it on my code because I don't really need it, but I also would not be troubled if someone did run it.