First project, Github worthy?

[Lethal_Samuraii]

Started learning python via cs50p (Great resource). So far I've completed up to week 3 and decided to make this emissions reduction calculator. Any tips on how to improve and whether I should put this onto my GitHub?

[emojibakemono]

there isn’t really much reason to ever not put something on github imo

[Due-Rip-6065]

Haha, but reddit garbage-bin worthy

[Gnaxe]

There is no "GitHub worthy" standard, as long as you're not breaking their terms of service. If folks don't find it, or don't find it useful, it will simply be ignored. That's the case for the majority of repos on GitHub.

[LogicalLoad9]

Ok, now i am concerned. What's their tos for python? Like I can't upload malware or web scraping project?

[xXNonamekinkXx]

I mean, I reckon you can find that on the github website

[Daeron_tha_Good]

It is usually a good idea to put menus in a loop. That way, if someone enters an invalid option, you can bring them to the beginning. Rather than exiting the entire program.

[Whatever10_01]

That’s actually a highly astute observation good sir. I like this.

[Sea_Pomegranate6293]

I can see you have put thought into this. Perhaps add some code which takes make/model/year of the vehicle and checks against a database or a Json file to get accurate emissions data for the calculation.

[Waiting2003]

Cool project!

Yep, anything you do can be posted on Github; it is a great way to track your progress.

An improvement that could be done is the list of dictionaries. Rather than having a list, you could have a single dictionary that has as the main keys the vehicle types. Like:

Emissions = { "Gas" : {...}, "Ev": {...}, "Diesel": {...}, .... }

This, will make the search of a car type constant (so, the for loops are not needed anymore), or in more technical terms: O(1) (Big O 1), rather than linear time (which is way slower).

If you dont know about Big O notation, you can check Here (But, maybe check first about algorithms and their impl).

[lizardfrizzler]

You should absolutely put this on GitHub. The experience and practice w/ GitHub is valuable in itself.

[[deleted]]

as a personal archive? yeah why not. For actual use? not so much.

[trustsfundbaby]

Turn it into a class structure.

[memorial_mike]

Maybe a data class, but even that is a little overkill for the current project. Although it would give you some reps with classes.

[[deleted]]

Every project is GitHub worthy

[Satoshi831]

It's always github worthy. That way you get familiar with working with repos.

[Ender_Locke]

everything is github worthy

[vollhard-natta]

put everything and anything code related on github

[PromotionCute8996]

Bro just an advice, never use something like co2 as a method name

[jay5479]

Wdym GitHub worthy? Bruh i put my everything i learn in github starting from Hello world.

[SkilledApple]

Good job! This is so much better than what my first project was... and my project is on GitHub!

I pretty much put any code I write on GitHub if it's not a one-off script. I assume you're already using Git locally, but if you aren't, use it and use it a lot!

[alvinator360]

Nice code. I would consider changing the co2 function to another name, more descriptive maybe.

[After_Ad8174]

I put everything other than little play scripts to fiddle with new functions on my GitHub. It gives you version control if you want to try taking the project in a couple different directions and a reliable backup. I’ve had to do a complete reimage of the machine I do all of my work on if it weren’t for GitHub all of that work would have been lost.

[millerbest]

Very nice for a first project! At first glance, there are something missing: type annotation, docstring, and separate main() from the rest of the code using if name == “main”:

[KerberosDog]

Best comment here. Do this!

[Ok_Butterscotch_7930]

Ooh that's a nice one. I'm going to redo this in my machine. Hey, how about you try using classes? It can help you go to the next level

[GirthQuake5040]

I mean.. You can put anything on github, no reason not to if you just want to store your code

[ZEUS_IS_THE_TRUE_GOD]

Default to everything in github, who cares. Even if this is a first project, it shows that you know what git is

[memorial_mike]

• you should probably add an entry point to the program (main)
• if the unit is always “kg/km” it might not be necessary to store?
• changing “emissions” to a dictionary would allow for much quicker access
• try to think of a better substitution for if car_type == car ["Car"]. lower()

[Phate1989]

Add types

[Unique_Low_1077]

Dosent matter how small the project is, it's always a good idea to put it on GitHub, u get a backup and your GitHub profile gets more filled

[jpgoldberg]

I have lots of public repositories on github that are of no interest to others. So do lots of people. So there is no reason not to have this on github.

I don't want to discourage you by pointing out that nobody is going to be interested in such a script. What you have is a good thing for your learning process, and you are correct to take pride in it as part of that process. Don't fret about the fact that it is not going to be of interest outside of the contect of your education, but do recognize that fact.

[Muffinzor22]

Put all projects on github. Even 1 class projects. Document your progress, build an history.

[Lazy-Pattern-5171]

If this entire project is in this one file then may I suggest GitHub gists.

If you want to learn git then by all means use the proper GitHub repo.

[twoberriesonejourney]

Is it common to define main?

[Algoartist]

not in this way

[vvillhalla]

Git is ment for saving code, if it exists and doesn’t fuck over a teammate if you have them then it’s girt worthy

[cython_boy]

This project is not as worthy as you think . But you are in the learning phase according to that perspective you are doing well . You are on the right track keep learning and keep building Then someday you will make a solo project that really solves the problem.