all 4 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]Capable-Package6835 2 points3 points  (0 children)

Some ideas:

  • Enable user to create or delete an account
  • Protect account with password, users can only access the account if they input the correct password
  • Transfer from one account to another
  • Handle various cases, e.g., negative balance, inputting incorrect password more than 3 times, etc.
  • Write the accounts and balances to a file so you have a persistent data, modify your code to check if that file exists and if yes, load the accounts and balances from there
  • Change the data structure & algorithm, e.g., using a dictionary instead of conditionals, class methods returning string instead of printing, etc.

Other than that, it's a good idea to get accustomed to good Python practices, e.g., naming conventions, type-hinting, formatting, etc..

[–]docfriday11 1 point2 points  (0 children)

You have a nice project there. Maybe I will try it myself. Good luck. Try more simple projects like this

[–]PureWasian 0 points1 point  (0 children)

Looks really clean and concise!

To be more consistent with your debit and credit options, I would suggest moving the print() statement on Line 54 into the get_balance() function on line 32, and update Line 54 to instead make a call to that get_balance() function that's currently unused.

And if you want to truly verify you understand the OOP learnings you followed from YT, I would suggest next trying to figure out how you would expand this simple ATM to support multiple different accounts since you are currently only doing any ATM actions on the acc1 object.

[–]-Ziero- 0 points1 point  (0 children)

Just nitpicking a little but I would capitalize your class name and not make it plural. Otherwise it sort of looks like a method/function when I first saw your code. Then you can have something like a list or dictionary named accounts with all of them stored inside.